Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: James Almer <jamrial@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: [FFmpeg-devel] [PATCH 02/13] avcodec/codec_par: add side data to AVCodecParameters
Date: Thu, 20 Jul 2023 17:34:04 -0300
Message-ID: <20230720203415.41757-2-jamrial@gmail.com> (raw)
In-Reply-To: <20230720203415.41757-1-jamrial@gmail.com>

Signed-off-by: James Almer <jamrial@gmail.com>
---
 libavcodec/codec_par.c | 36 ++++++++++++++++++++++++++++++++++++
 libavcodec/codec_par.h |  6 ++++++
 2 files changed, 42 insertions(+)

diff --git a/libavcodec/codec_par.c b/libavcodec/codec_par.c
index 775c187073..c113cfcd80 100644
--- a/libavcodec/codec_par.c
+++ b/libavcodec/codec_par.c
@@ -27,11 +27,13 @@
 #include "libavutil/mem.h"
 #include "avcodec.h"
 #include "codec_par.h"
+#include "packet.h"
 
 static void codec_parameters_reset(AVCodecParameters *par)
 {
     av_freep(&par->extradata);
     av_channel_layout_uninit(&par->ch_layout);
+    av_packet_free_side_data_set(&par->side_data_set);
 
     memset(par, 0, sizeof(*par));
 
@@ -72,6 +74,29 @@ void avcodec_parameters_free(AVCodecParameters **ppar)
     av_freep(ppar);
 }
 
+static int codec_parameters_copy_side_data(AVPacketSideDataSet *dst,
+                                           const AVPacketSideDataSet *src)
+{
+    if (!src->nb_side_data)
+        return 0;
+
+    dst->side_data = av_calloc(src->nb_side_data, sizeof(*dst->side_data));
+    if (!dst->side_data)
+        return AVERROR(ENOMEM);
+
+    for (int i = 0; i < src->nb_side_data; i++) {
+        uint8_t *data = av_memdup(src->side_data[i].data, src->side_data[i].size);
+        if (!data)
+            return AVERROR(ENOMEM);
+        dst->side_data[i].type = src->side_data[i].type;
+        dst->side_data[i].size = src->side_data[i].size;
+        dst->side_data[i].data = data;
+        dst->nb_side_data++;
+    }
+
+    return 0;
+}
+
 int avcodec_parameters_copy(AVCodecParameters *dst, const AVCodecParameters *src)
 {
     int ret;
@@ -89,6 +114,10 @@ int avcodec_parameters_copy(AVCodecParameters *dst, const AVCodecParameters *src
         memcpy(dst->extradata, src->extradata, src->extradata_size);
         dst->extradata_size = src->extradata_size;
     }
+    memset(&dst->side_data_set, 0, sizeof(dst->side_data_set));
+    ret = codec_parameters_copy_side_data(&dst->side_data_set, &src->side_data_set);
+    if (ret < 0)
+        return ret;
 
     ret = av_channel_layout_copy(&dst->ch_layout, &src->ch_layout);
     if (ret < 0)
@@ -177,6 +206,9 @@ FF_ENABLE_DEPRECATION_WARNINGS
         memcpy(par->extradata, codec->extradata, codec->extradata_size);
         par->extradata_size = codec->extradata_size;
     }
+    ret = codec_parameters_copy_side_data(&par->side_data_set, &codec->side_data_set);
+    if (ret < 0)
+        return ret;
 
     return 0;
 }
@@ -261,6 +293,10 @@ FF_ENABLE_DEPRECATION_WARNINGS
         memcpy(codec->extradata, par->extradata, par->extradata_size);
         codec->extradata_size = par->extradata_size;
     }
+    av_packet_free_side_data_set(&codec->side_data_set);
+    ret = codec_parameters_copy_side_data(&codec->side_data_set, &par->side_data_set);
+    if (ret < 0)
+        return ret;
 
     return 0;
 }
diff --git a/libavcodec/codec_par.h b/libavcodec/codec_par.h
index add90fdb1e..06e9d54615 100644
--- a/libavcodec/codec_par.h
+++ b/libavcodec/codec_par.h
@@ -29,6 +29,7 @@
 #include "libavutil/pixfmt.h"
 
 #include "codec_id.h"
+#include "packet.h"
 
 /**
  * @addtogroup lavc_core
@@ -223,6 +224,11 @@ typedef struct AVCodecParameters {
      * when no higher-level timing information is available.
      */
     AVRational framerate;
+
+    /**
+     * Additional data associated with the entire stream.
+     */
+    AVPacketSideDataSet side_data_set;
 } AVCodecParameters;
 
 /**
-- 
2.41.0

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2023-07-20 20:34 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-20 20:34 [FFmpeg-devel] [PATCH 01/13] avcodec/avcodec: add side data to AVCodecContext James Almer
2023-07-20 20:34 ` James Almer [this message]
2023-07-20 20:34 ` [FFmpeg-devel] [PATCH 03/13] avformat/avformat: use the side data from AVStream.codecpar James Almer
2023-07-20 20:34 ` [FFmpeg-devel] [PATCH 04/13] fftools/ffmpeg: stop using AVStream.side_data James Almer
2023-07-20 20:34 ` [FFmpeg-devel] [PATCH 05/13] fftools/ffplay: " James Almer
2023-07-20 20:34 ` [FFmpeg-devel] [PATCH 06/13] fftools/ffprobe: " James Almer
2023-07-20 20:34 ` [FFmpeg-devel] [PATCH 07/13] avcodec/hevcdec: check for DOVI configuration record in AVCodecContext side data James Almer
2023-07-23  8:40   ` Andreas Rheinhardt
2023-07-23 11:48     ` James Almer
2023-07-23 12:17       ` Andreas Rheinhardt
2023-07-23 12:22         ` James Almer
2023-07-23 12:56         ` [FFmpeg-devel] [PATCH v2 " James Almer
2023-07-20 20:34 ` [FFmpeg-devel] [PATCH 08/13] avcodec/decode: check for global side data " James Almer
2023-07-23 12:57   ` [FFmpeg-devel] [PATCH v2 " James Almer
2023-07-20 20:34 ` [FFmpeg-devel] [PATCH 09/13] fftools/ffmpeg: stop injecting stream side data in packets James Almer
2023-07-20 20:34 ` [FFmpeg-devel] [PATCH 10/13] fftools/ffplay: " James Almer
2023-07-20 20:34 ` [FFmpeg-devel] [PATCH 11/13] avcodec/avcodec: deprecate coded_side_data James Almer
2023-07-20 20:34 ` [FFmpeg-devel] [PATCH 12/13] avformat/demux: stop copying the internal AVCodecContext coded_side_data James Almer
2023-07-20 20:34 ` [FFmpeg-devel] [PATCH 13/13] fftools: stop propagating the encoder's coded_side_data James Almer
2023-07-22 22:49 ` [FFmpeg-devel] [PATCH 01/13] avcodec/avcodec: add side data to AVCodecContext James Almer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230720203415.41757-2-jamrial@gmail.com \
    --to=jamrial@gmail.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git