From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: [FFmpeg-devel] [PATCH 14/14] avradio/sdrdemux: Fix wraparound with seeking
Date: Tue, 18 Jul 2023 23:45:42 +0200
Message-ID: <20230718214542.685375-14-michael@niedermayer.cc> (raw)
In-Reply-To: <20230718214542.685375-1-michael@niedermayer.cc>
This implementation is clean and requires no communication between the
threads. It requires a few more lines than i would like though
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
---
libavradio/sdr.h | 1 +
libavradio/sdrdemux.c | 13 ++++++++++++-
2 files changed, 13 insertions(+), 1 deletion(-)
diff --git a/libavradio/sdr.h b/libavradio/sdr.h
index 3f76aec2a6..c651ba0d99 100644
--- a/libavradio/sdr.h
+++ b/libavradio/sdr.h
@@ -171,6 +171,7 @@ typedef struct SDRContext {
int kbd_alpha;
AVComplexFloat *windowed_block;
int64_t block_center_freq; ///< center frequency the current block contains
+ int wraparound;
int64_t station_freq;
int64_t user_wanted_freq;
int sample_size;
diff --git a/libavradio/sdrdemux.c b/libavradio/sdrdemux.c
index 65b5e6df8d..8967ff1ea9 100644
--- a/libavradio/sdrdemux.c
+++ b/libavradio/sdrdemux.c
@@ -1307,7 +1307,9 @@ static int snap2station(SDRContext *sdr, int *seek_direction) {
Station *station_list[MAX_STATIONS];
int nb_stations;
- if (sst->station) {
+ if (sdr->wraparound) {
+ current_freq = (*seek_direction) > 0 ? 0 : INT64_MAX;
+ } else if (sst->station) {
current_freq = sst->station->frequency;
} else if (sdr->station_freq) {
current_freq = sdr->station_freq;
@@ -1354,6 +1356,7 @@ static int snap2station(SDRContext *sdr, int *seek_direction) {
*seek_direction = 0;
atomic_store(&sdr->seek_direction, 0);
atomic_store(&sdr->wanted_freq, wanted_freq);
+ sdr->wraparound = 0;
//200*1000 had artifacts
av_log(avfmt, AV_LOG_DEBUG, "request f = %"PRId64"\n", atomic_load(&sdr->wanted_freq));
@@ -2021,6 +2024,13 @@ process_next_block:
ret = snap2station(sdr, &seek_direction);
if (ret < 0)
return ret;
+ if (seek_direction && !ret) {
+ int wrapdir = sdr->wraparound == 0 ? seek_direction : -seek_direction;
+ int64_t end_freq = snap2band(sdr, wrapdir > 0 ? 0 : INT64_MAX, wrapdir);
+ if (fabs(end_freq - sdr->block_center_freq) < 1500)
+ sdr->wraparound++;
+
+ }
}
} else {
av_assert0(sdr->mode == AllStationMode);
@@ -2104,6 +2114,7 @@ int ff_sdr_read_seek(AVFormatContext *s, int stream_index,
return ret;
//snap2station found no station lets command the thread to seek
if (!ret) {
+ sdr->wraparound = 0;
atomic_store(&sdr->seek_direction, dir);
flush_fifo(sdr, sdr->full_block_fifo);
}
--
2.31.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-07-18 21:47 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-18 21:45 [FFmpeg-devel] [PATCH 01/14] avradio/sdrdemux: Add Mittelwelle / Mediumwave / Mediumfrequency band Michael Niedermayer
2023-07-18 21:45 ` [FFmpeg-devel] [PATCH 02/14] avradio/sdrdemux: Fix corner case in snap2band Michael Niedermayer
2023-07-18 21:45 ` [FFmpeg-devel] [PATCH 03/14] avradio/sdrdemux: Fix seeking to stations at the edge of the range Michael Niedermayer
2023-07-18 21:45 ` [FFmpeg-devel] [PATCH 04/14] avradio/sdrdemux: snap2station() should look only at the vissible window Michael Niedermayer
2023-07-18 21:45 ` [FFmpeg-devel] [PATCH 05/14] avradio/sdr: snap2station() documentation Michael Niedermayer
2023-07-18 21:45 ` [FFmpeg-devel] [PATCH 06/14] avradio/sdrdemux: do not hack bandwidth value in random places Michael Niedermayer
2023-07-18 21:45 ` [FFmpeg-devel] [PATCH 07/14] avradio/sdrdemux: snap2station consider more distant stations Michael Niedermayer
2023-07-18 21:45 ` [FFmpeg-devel] [PATCH 08/14] tests: Add avradio/sdrdemux tests Michael Niedermayer
2023-07-21 18:42 ` Michael Niedermayer
2023-07-21 23:51 ` Michael Niedermayer
2023-07-18 21:45 ` [FFmpeg-devel] [PATCH 09/14] avradio/sdr: Remove code setting frequency from variable being 0 Michael Niedermayer
2023-07-18 21:45 ` [FFmpeg-devel] [PATCH 10/14] avradio/sdrdemux: no need to set wanted_freq from sdrfile_initial_setup() Michael Niedermayer
2023-07-18 21:45 ` [FFmpeg-devel] [PATCH 11/14] avradio/sdr: More atomics, less Mutexes Michael Niedermayer
2023-07-18 21:45 ` [FFmpeg-devel] [PATCH 12/14] avradio/sdrdemux: + vs. - bug Michael Niedermayer
2023-07-18 21:45 ` [FFmpeg-devel] [PATCH 13/14] avradio/sdrdemux: snap2band doesnt change anything so use const Michael Niedermayer
2023-07-18 21:45 ` Michael Niedermayer [this message]
2023-07-22 13:30 ` [FFmpeg-devel] [PATCH 01/14] avradio/sdrdemux: Add Mittelwelle / Mediumwave / Mediumfrequency band Michael Niedermayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230718214542.685375-14-michael@niedermayer.cc \
--to=michael@niedermayer.cc \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git