From: Anton Khirnov <anton@khirnov.net> To: ffmpeg-devel@ffmpeg.org Subject: [FFmpeg-devel] [PATCH 46/47] fftools/ffprobe: stop calling exit_program() Date: Sat, 15 Jul 2023 12:46:10 +0200 Message-ID: <20230715104611.17902-46-anton@khirnov.net> (raw) In-Reply-To: <20230715104611.17902-1-anton@khirnov.net> Inline the relevant part of ffprobe_cleanup() into main() and drop the rest. --- fftools/ffprobe.c | 22 ++++++++-------------- 1 file changed, 8 insertions(+), 14 deletions(-) diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c index e234c92904..a39185f6fe 100644 --- a/fftools/ffprobe.c +++ b/fftools/ffprobe.c @@ -381,17 +381,6 @@ static void log_callback(void *ptr, int level, const char *fmt, va_list vl) #endif } -static void ffprobe_cleanup(int ret) -{ - int i; - for (i = 0; i < FF_ARRAY_ELEMS(sections); i++) - av_dict_free(&(sections[i].entries_to_show)); - -#if HAVE_THREADS - pthread_mutex_destroy(&log_mutex); -#endif -} - struct unit_value { union { double d; long long int i; } val; const char *unit; @@ -4113,7 +4102,6 @@ int main(int argc, char **argv) } #endif av_log_set_flags(AV_LOG_SKIP_REPEATED); - register_exit(ffprobe_cleanup); options = real_options; parse_loglevel(argc, argv, options); @@ -4124,8 +4112,10 @@ int main(int argc, char **argv) show_banner(argc, argv, options); ret = parse_options(NULL, argc, argv, options, opt_input_file); - if (ret < 0) - exit_program(ret == AVERROR_EXIT ? 0 : 1); + if (ret < 0) { + ret = AVERROR_EXIT ? 0 : ret; + goto end; + } if (do_show_log) av_log_set_callback(log_callback); @@ -4249,5 +4239,9 @@ end: avformat_network_deinit(); +#if HAVE_THREADS + pthread_mutex_destroy(&log_mutex); +#endif + return ret < 0; } -- 2.40.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-07-15 10:51 UTC|newest] Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-07-15 10:45 [FFmpeg-devel] [PATCH 01/47] fftools/ffmpeg_mux_init: handle pixel format endianness Anton Khirnov 2023-07-15 10:45 ` [FFmpeg-devel] [PATCH 02/47] fftools/ffmpeg_filter: move "smart" pixfmt selection to ffmpeg_mux_init Anton Khirnov 2023-07-15 10:45 ` [FFmpeg-devel] [PATCH 03/47] fftools/ffmpeg_mux_init: deprecate "smart" pixel format selection Anton Khirnov 2023-07-15 10:45 ` [FFmpeg-devel] [PATCH 04/47] tests/fate: fix mismatches between requested and actually used pixel formats Anton Khirnov 2023-07-15 10:45 ` [FFmpeg-devel] [PATCH 05/47] fftools/ffmpeg_filter: stop accessing encoder from pixfmt selection Anton Khirnov 2023-07-15 10:45 ` [FFmpeg-devel] [PATCH 06/47] fftools/ffmpeg_filter: restrict reap_filters() to a single filtergraph Anton Khirnov 2023-07-15 10:45 ` [FFmpeg-devel] [PATCH 07/47] fftools/ffmpeg_mux_init: avoid invalid memory access in set_dispositions() Anton Khirnov 2023-07-15 10:45 ` [FFmpeg-devel] [PATCH 08/47] fftools/ffmpeg_enc: return errors from enc_frame() instead of aborting Anton Khirnov 2023-07-15 10:45 ` [FFmpeg-devel] [PATCH 09/47] fftools/ffmpeg_enc: return errors from enc_open() " Anton Khirnov 2023-07-15 10:45 ` [FFmpeg-devel] [PATCH 10/47] fftools/ffmpeg_enc: return errors from do_*_out() " Anton Khirnov 2023-07-15 10:45 ` [FFmpeg-devel] [PATCH 11/47] fftools/ffmpeg_enc: return errors from enc_flush() " Anton Khirnov 2023-07-15 10:45 ` [FFmpeg-devel] [PATCH 12/47] fftools/ffmpeg_enc: return errors from encode_frame() " Anton Khirnov 2023-07-15 10:45 ` [FFmpeg-devel] [PATCH 13/47] fftools/ffmpeg_mux: return errors from of_output_packet() " Anton Khirnov 2023-07-15 10:45 ` [FFmpeg-devel] [PATCH 14/47] fftools/ffmpeg_dec: return error codes from dec_packet() " Anton Khirnov 2023-07-15 10:45 ` [FFmpeg-devel] [PATCH 15/47] fftools/ffmpeg_dec: drop redundant handling of AVERROR_EXPERIMENTAL Anton Khirnov 2023-07-15 10:45 ` [FFmpeg-devel] [PATCH 16/47] fftools/ffmpeg_filter: return error codes from ofilter_bind_ost() instead of aborting Anton Khirnov 2023-07-15 10:45 ` [FFmpeg-devel] [PATCH 17/47] fftools/ffmpeg_filter: return error codes from init_input_filter() " Anton Khirnov 2023-07-15 10:45 ` [FFmpeg-devel] [PATCH 18/47] fftools/ffmpeg_filter: replace remaining exit_program() with error codes Anton Khirnov 2023-07-15 10:45 ` [FFmpeg-devel] [PATCH 19/47] fftools/ffmpeg_filter: return error codes from choose_pix_fmts() instead of aborting Anton Khirnov 2023-07-15 10:45 ` [FFmpeg-devel] [PATCH 20/47] fftools/ffmpeg_filter: return error codes from fg_create() " Anton Khirnov 2023-07-15 10:45 ` [FFmpeg-devel] [PATCH 21/47] fftools/ffmpeg_filter: return error codes from set_channel_layout() " Anton Khirnov 2023-07-15 10:45 ` [FFmpeg-devel] [PATCH 22/47] fftools/ffmpeg_filter: replace remaining report_and_exit() with error codes Anton Khirnov 2023-07-15 10:45 ` [FFmpeg-devel] [PATCH 23/47] fftools/cmdutils: return error codes from setup_find_stream_info_opts() instead of aborting Anton Khirnov 2023-07-15 10:45 ` [FFmpeg-devel] [PATCH 24/47] fftools/ffmpeg_opt: reimplement -streamid using a dictionary Anton Khirnov 2023-07-15 10:45 ` [FFmpeg-devel] [PATCH 25/47] fftools/cmdutils: drop unused ALLOC_ARRAY_ELEM() Anton Khirnov 2023-07-15 10:45 ` [FFmpeg-devel] [PATCH 26/47] fftools/cmdutils: add error handling to allocate_array_elem() Anton Khirnov 2023-07-15 10:45 ` [FFmpeg-devel] [PATCH 27/47] fftools/cmdutils: add error handling to grow_array() Anton Khirnov 2023-07-15 10:45 ` [FFmpeg-devel] [PATCH 28/47] fftools/cmdutils: add error handling to GROW_ARRAY() Anton Khirnov 2023-07-15 10:45 ` [FFmpeg-devel] [PATCH 29/47] fftools/ffmpeg: return errors from find_codec_or_die() instead of aborting Anton Khirnov 2023-07-15 10:45 ` [FFmpeg-devel] [PATCH 30/47] fftools/ffmpeg_opt: replace exit_program() with returning error codes Anton Khirnov 2023-07-15 10:45 ` [FFmpeg-devel] [PATCH 31/47] fftools/opt_common: " Anton Khirnov 2023-07-15 10:45 ` [FFmpeg-devel] [PATCH 32/47] fftools: return errors from parse_number_or_die() instead of aborting Anton Khirnov 2023-07-15 10:45 ` [FFmpeg-devel] [PATCH 33/47] fftools: remove parse_time_or_die() Anton Khirnov 2023-07-15 10:45 ` [FFmpeg-devel] [PATCH 34/47] fftools: handle errors in parse_options() Anton Khirnov 2023-07-15 10:45 ` [FFmpeg-devel] [PATCH 35/47] fftools/cmdutils: constify the first parameter of filter_codec_opts() Anton Khirnov 2023-07-15 10:46 ` [FFmpeg-devel] [PATCH 36/47] fftools/cmdutils: add error handling to filter_codec_opts() Anton Khirnov 2023-07-15 10:46 ` [FFmpeg-devel] [PATCH 37/47] fftools/ffmpeg_opt: consolidate printing errors in ffmpeg_parse_options() Anton Khirnov 2023-07-15 10:46 ` [FFmpeg-devel] [PATCH 38/47] fftools/ffmpeg: consolidate exiting from main() on error Anton Khirnov 2023-07-15 10:46 ` [FFmpeg-devel] [PATCH 39/47] fftools/cmdutils: return AVERROR_EXIT for OPT_EXIT options instead of aborting() Anton Khirnov 2023-07-15 10:46 ` [FFmpeg-devel] [PATCH 40/47] fftools/ffmpeg: return an error from assert_avoptions() instead of aborting Anton Khirnov 2023-07-15 10:46 ` [FFmpeg-devel] [PATCH 41/47] fftools/ffmpeg: return an error from MATCH_PER_STREAM_OPT() " Anton Khirnov 2023-07-15 10:46 ` [FFmpeg-devel] [PATCH 42/47] fftools/ffprobe: replace report_and_exit() with returning error codes Anton Khirnov 2023-07-15 10:46 ` [FFmpeg-devel] [PATCH 43/47] fftools/ffplay: replace report_and_exit() with returning an error code Anton Khirnov 2023-07-15 10:46 ` [FFmpeg-devel] [PATCH 44/47] fftools/opt_common: " Anton Khirnov 2023-07-15 10:46 ` [FFmpeg-devel] [PATCH 45/47] fftools/ffprobe: inline opt_output_file() into its only caller Anton Khirnov 2023-08-02 5:28 ` Stefano Sabatini 2023-07-15 10:46 ` Anton Khirnov [this message] 2023-07-20 20:35 ` [FFmpeg-devel] [PATCH 46/47] fftools/ffprobe: stop calling exit_program() Marton Balint 2023-07-21 12:06 ` Anton Khirnov 2023-07-21 12:14 ` Anton Khirnov 2023-08-02 5:32 ` Stefano Sabatini 2023-07-15 10:46 ` [FFmpeg-devel] [PATCH 47/47] fftools/ffmpeg: " Anton Khirnov 2023-07-20 18:56 ` [FFmpeg-devel] [PATCH 01/47] fftools/ffmpeg_mux_init: handle pixel format endianness Anton Khirnov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230715104611.17902-46-anton@khirnov.net \ --to=anton@khirnov.net \ --cc=ffmpeg-devel@ffmpeg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git