From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 681C646E47 for ; Fri, 14 Jul 2023 18:45:08 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 435FA68C645; Fri, 14 Jul 2023 21:45:06 +0300 (EEST) Received: from ursule.remlab.net (vps-a2bccee9.vps.ovh.net [51.75.19.47]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8712868C2D3 for ; Fri, 14 Jul 2023 21:44:59 +0300 (EEST) Received: from basile.remlab.net (localhost [IPv6:::1]) by ursule.remlab.net (Postfix) with ESMTP id 21E4FC000E for ; Fri, 14 Jul 2023 21:44:59 +0300 (EEST) From: =?UTF-8?q?R=C3=A9mi=20Denis-Courmont?= To: ffmpeg-devel@ffmpeg.org Date: Fri, 14 Jul 2023 21:44:58 +0300 Message-Id: <20230714184458.67532-1-remi@remlab.net> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH] checkasm: print usage on invalid arguments X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: This checks that arguments are handled. If not, then this prints a short usage notice and returns an error. --- tests/checkasm/checkasm.c | 34 +++++++++++++++++++++++----------- 1 file changed, 23 insertions(+), 11 deletions(-) diff --git a/tests/checkasm/checkasm.c b/tests/checkasm/checkasm.c index d72850f076..fafa4a0c82 100644 --- a/tests/checkasm/checkasm.c +++ b/tests/checkasm/checkasm.c @@ -756,6 +756,14 @@ static void bench_uninit(void) #endif } +static int usage(const char *path) +{ + fprintf(stderr, + "Usage: %s [--bench] [--test=] [--verbose] [seed]\n", + path); + return 1; +} + int main(int argc, char *argv[]) { unsigned int seed = av_get_random_seed(); @@ -771,25 +779,29 @@ int main(int argc, char *argv[]) return 0; } - while (argc > 1) { - if (!strncmp(argv[1], "--bench", 7)) { + for (i = 1; i < argc; i++) { + const char *arg = argv[i]; + unsigned long l; + char *end; + + if (!strncmp(arg, "--bench", 7)) { if (bench_init() < 0) return 1; - if (argv[1][7] == '=') { - state.bench_pattern = argv[1] + 8; + if (arg[7] == '=') { + state.bench_pattern = arg + 8; state.bench_pattern_len = strlen(state.bench_pattern); } else state.bench_pattern = ""; - } else if (!strncmp(argv[1], "--test=", 7)) { - state.test_name = argv[1] + 7; - } else if (!strcmp(argv[1], "--verbose") || !strcmp(argv[1], "-v")) { + } else if (!strncmp(arg, "--test=", 7)) { + state.test_name = arg + 7; + } else if (!strcmp(arg, "--verbose") || !strcmp(arg, "-v")) { state.verbose = 1; + } else if ((l = strtoul(arg, &end, 10)) <= UINT_MAX && + *end == '\0') { + seed = l; } else { - seed = strtoul(argv[1], NULL, 10); + return usage(argv[0]); } - - argc--; - argv++; } fprintf(stderr, "checkasm: using random seed %u\n", seed); -- 2.40.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".