From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 0CE1C462F8 for ; Fri, 14 Jul 2023 18:12:56 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1345068C621; Fri, 14 Jul 2023 21:12:54 +0300 (EEST) Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [217.70.183.194]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 80DCA68C4CE for ; Fri, 14 Jul 2023 21:12:47 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id B540C40004 for ; Fri, 14 Jul 2023 18:12:46 +0000 (UTC) Date: Fri, 14 Jul 2023 20:12:45 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20230714181245.GN1093384@pb2> References: <20230713105553.21052-1-anton@khirnov.net> <20230713105553.21052-16-anton@khirnov.net> <20230713233024.GL1093384@pb2> <168932563922.27367.17493759052457548791@lain.khirnov.net> MIME-Version: 1.0 In-Reply-To: <168932563922.27367.17493759052457548791@lain.khirnov.net> X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH 16/33] fftools/ffmpeg_mux_init: improve of_add_programs() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============3304885837318195036==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============3304885837318195036== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="0oEQci8Wf3TZ4Qnh" Content-Disposition: inline --0oEQci8Wf3TZ4Qnh Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jul 14, 2023 at 11:07:19AM +0200, Anton Khirnov wrote: > Quoting Michael Niedermayer (2023-07-14 01:30:24) > > On Thu, Jul 13, 2023 at 12:55:36PM +0200, Anton Khirnov wrote: > > > Replace duplicated(!) and broken* custom string parsing with > > > av_dict_parse_string(). Return error codes instead of aborting. > > >=20 > > > * e.g. it treats NULL returned from av_get_token() as "separator not > > > found", when in fact av_get_token() only returns NULL on memory > > > allocation failure > > > --- > > > fftools/ffmpeg_mux_init.c | 111 ++++++++++++++++++------------------= -- > > > 1 file changed, 52 insertions(+), 59 deletions(-) > >=20 > > smells like memory corruption > >=20 > > -i ~/videos/01c56b0dc1.ts -copy_unknown -map 0 -c copy -fflags +bitexac= t -t 3 -y file-copy-unknown.ts >=20 > I have no idea why are you replying to this specific patch, when this > issue apparently exists in current master. git bisect of a segfault lead me to this one with memory corruption, its quite possible it doesnt always segfault so git bisect results can be bogus sorry [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Take away the freedom of one citizen and you will be jailed, take away the freedom of all citizens and you will be congratulated by your peers in Parliament. --0oEQci8Wf3TZ4Qnh Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZLGQGQAKCRBhHseHBAsP q6/kAJ0Q97i+57jDTB2Z0X3ZCYYGN1xJ3QCfeEHReTyXnvzP/BT4PVoNcEQex6k= =VMYB -----END PGP SIGNATURE----- --0oEQci8Wf3TZ4Qnh-- --===============3304885837318195036== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============3304885837318195036==--