On Fri, Jul 14, 2023 at 11:07:19AM +0200, Anton Khirnov wrote: > Quoting Michael Niedermayer (2023-07-14 01:30:24) > > On Thu, Jul 13, 2023 at 12:55:36PM +0200, Anton Khirnov wrote: > > > Replace duplicated(!) and broken* custom string parsing with > > > av_dict_parse_string(). Return error codes instead of aborting. > > > > > > * e.g. it treats NULL returned from av_get_token() as "separator not > > > found", when in fact av_get_token() only returns NULL on memory > > > allocation failure > > > --- > > > fftools/ffmpeg_mux_init.c | 111 ++++++++++++++++++-------------------- > > > 1 file changed, 52 insertions(+), 59 deletions(-) > > > > smells like memory corruption > > > > -i ~/videos/01c56b0dc1.ts -copy_unknown -map 0 -c copy -fflags +bitexact -t 3 -y file-copy-unknown.ts > > I have no idea why are you replying to this specific patch, when this > issue apparently exists in current master. git bisect of a segfault lead me to this one with memory corruption, its quite possible it doesnt always segfault so git bisect results can be bogus sorry [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Take away the freedom of one citizen and you will be jailed, take away the freedom of all citizens and you will be congratulated by your peers in Parliament.