From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: [FFmpeg-devel] [PATCH 04/14] avradio/sdrdemux: Compute FM station frequency more exactly
Date: Thu, 13 Jul 2023 01:36:56 +0200
Message-ID: <20230712233706.449054-4-michael@niedermayer.cc> (raw)
In-Reply-To: <20230712233706.449054-1-michael@niedermayer.cc>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
---
libavradio/sdrdemux.c | 35 ++++++++++++++++++++++++++++++++---
1 file changed, 32 insertions(+), 3 deletions(-)
diff --git a/libavradio/sdrdemux.c b/libavradio/sdrdemux.c
index fea4202709..fd3f5dd52d 100644
--- a/libavradio/sdrdemux.c
+++ b/libavradio/sdrdemux.c
@@ -383,6 +383,7 @@ static int create_candidate_station(SDRContext *sdr, enum Modulation modulation,
Station *station_list[1000];
double snapdistance = modulation == AM ? AM_FREQ_TOLERANCE : FM_FREQ_TOLERANCE;
int nb_stations = ff_sdr_find_stations(sdr, freq, snapdistance, station_list, FF_ARRAY_ELEMS(station_list));
+ int update_freq = 1;
if (nb_stations) {
for(int i = 1; i<nb_stations; i++)
@@ -409,12 +410,18 @@ static int create_candidate_station(SDRContext *sdr, enum Modulation modulation,
goto fail;
} else {
station = station_list[0];
+
+ //demodulated FM stations have their frequency computed exactly, so dont mess them up
+ update_freq = station->modulation != FM || !station->in_station_list || !sdr->demodulate_all_fm;
+
// We will update the frequency so we need to reinsert
tree_remove(&sdr->station_root, station, station_cmp, &next);
- station->frequency = station->nb_frequency * station->frequency + freq;
+ if (update_freq)
+ station->frequency = station->nb_frequency * station->frequency + freq;
station->timeout = 0;
}
- station->frequency /= ++station->nb_frequency;
+ if(update_freq)
+ station->frequency /= ++station->nb_frequency;
station->detection_per_mix_frequency[histogram_index(sdr, freq)] ++;
station->modulation = modulation;
@@ -934,6 +941,22 @@ static int probe_fm(SDRContext *sdr)
return 0;
}
+static void station_update_freq(SDRContext *sdr, Station *station, double freq)
+{
+ struct AVTreeNode *next = NULL;
+ void *tmp;
+
+ //We must reinsert the station if we change the key (frequency)
+ tree_remove(&sdr->station_root, station, station_cmp, &next);
+
+ station->frequency = station->nb_frequency * station->frequency + freq;
+ station->frequency /= ++station->nb_frequency;
+
+ tmp = tree_insert(&sdr->station_root, station, station_cmp, &next);
+ av_assert0(!tmp || tmp == station);
+ av_freep(&next);
+}
+
static int demodulate_fm(SDRContext *sdr, Station *station, AVStream *st, AVPacket *pkt)
{
SDRStream *sst = st ? st->priv_data : NULL;
@@ -953,11 +976,12 @@ static int demodulate_fm(SDRContext *sdr, Station *station, AVStream *st, AVPack
int len2_4_i = 2L*sdr->fm_block_size* 2400 / sample_rate;
double carrier19_i_exact;
int W= 5;
+ double dc = 0, dcw = 0;
+ int len2 = FFMIN(index, 2*sdr->block_size - index);
av_assert0(!st || (sst == station->stream && sst->station == station));
//If only some of the bandwidth is available, just try with less
- int len2 = FFMIN(index, 2*sdr->block_size - index);
if (len2 < len && len2 > len/2)
len = len2;
@@ -979,9 +1003,14 @@ static int demodulate_fm(SDRContext *sdr, Station *station, AVStream *st, AVPack
sdr->fm_iblock[i].re = atan2(x.im * y.re - x.re * y.im,
x.re * y.re + x.im * y.im) * sdr->fm_window[i];
sdr->fm_iblock[i].im = 0;
+ dc += sdr->fm_iblock[i].re;
+ dcw+= sdr->fm_window[i] * sdr->fm_window[i];
}
sdr->fm_iblock[i].re = 0;
sdr->fm_iblock[i].im = 0;
+ dc *= M_PI/2 * sqrt((2*sdr->fm_block_size - 1) / dcw);
+
+ station_update_freq(sdr, station, freq-dc);
av_assert0(sdr->fm_block_size_p2 * 2 < sdr->fm_block_size);
//FIXME this only needs to be a RDFT
--
2.31.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-07-12 23:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-12 23:36 [FFmpeg-devel] [PATCH 01/14] avradio/rds: reset station timeout on successfull group decode Michael Niedermayer
2023-07-12 23:36 ` [FFmpeg-devel] [PATCH 02/14] avradio/sdr: Factor demodulate_all_fm out Michael Niedermayer
2023-07-12 23:36 ` [FFmpeg-devel] [PATCH 03/14] avradio/sdrdemux: require better timeout for replacing station Michael Niedermayer
2023-07-12 23:36 ` Michael Niedermayer [this message]
2023-07-12 23:36 ` [FFmpeg-devel] [PATCH 05/14] avradio/sdrdemux: basic warning cleanup Michael Niedermayer
2023-07-12 23:36 ` [FFmpeg-devel] [PATCH 06/14] avradio/rds: Implement clearing radio text Michael Niedermayer
2023-07-12 23:36 ` [FFmpeg-devel] [PATCH 07/14] avradio/rds: Implement RadioText Plus Michael Niedermayer
2023-07-12 23:37 ` [FFmpeg-devel] [PATCH 08/14] avradio/rds: Better file title Michael Niedermayer
2023-07-12 23:37 ` [FFmpeg-devel] [PATCH 09/14] remove stray av_log() Michael Niedermayer
2023-07-12 23:37 ` [FFmpeg-devel] [PATCH 10/14] avradio/sdrdemux: Export RT+ metadata updates Michael Niedermayer
2023-07-12 23:37 ` [FFmpeg-devel] [PATCH 11/14] avradio/sdrdemux: Basic prefilter for RDS Michael Niedermayer
2023-07-12 23:37 ` [FFmpeg-devel] [PATCH 12/14] avradio/sdrdemux: Reduce FM audio bandwidth down toward reality Michael Niedermayer
2023-07-12 23:37 ` [FFmpeg-devel] [PATCH 13/14] avradio/sdrdemux: deemphasis filter fixes Michael Niedermayer
2023-07-12 23:37 ` [FFmpeg-devel] [PATCH 14/14] avradio/sdrdemux: Print log_debug level message on metadata changes Michael Niedermayer
2023-07-13 19:50 ` [FFmpeg-devel] [PATCH 01/14] avradio/rds: reset station timeout on successfull group decode Michael Niedermayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230712233706.449054-4-michael@niedermayer.cc \
--to=michael@niedermayer.cc \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git