Re: [FFmpeg-devel] [PATCH v2 13/14] vvcdec: add CTU thread logical

From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v2 13/14] vvcdec: add CTU thread logical
Date: Tue, 11 Jul 2023 19:28:49 +0200
Message-ID: <20230711172849.GF1093384@pb2> (raw)
In-Reply-To: <4954304.WHgzn753BY@basile.remlab.net>

[-- Attachment #1.1: Type: text/plain, Size: 1806 bytes --]

On Mon, Jul 10, 2023 at 06:04:06PM +0300, Rémi Denis-Courmont wrote:
> Le sunnuntaina 9. heinäkuuta 2023, 0.41.35 EEST Michael Niedermayer a écrit :
> > On Fri, Jul 07, 2023 at 10:05:39PM +0800, Nuo Mi wrote:
> > > This is the main entry point for the CTU (Coding Tree Unit) decoder.
> > > The code will divide the CTU decoder into several stages.
> > > It will check the stage dependencies and run the stage decoder.
> > > ---
> > > 
> > >  libavcodec/vvc/Makefile     |   3 +-
> > >  libavcodec/vvc/vvc_thread.c | 804 ++++++++++++++++++++++++++++++++++++
> > >  libavcodec/vvc/vvc_thread.h |  73 ++++
> > >  3 files changed, 879 insertions(+), 1 deletion(-)
> > >  create mode 100644 libavcodec/vvc/vvc_thread.c
> > >  create mode 100644 libavcodec/vvc/vvc_thread.h
> > 
> > seems not to build with enable-shared
> > 
> > src/libavcodec/vvc/vvc_thread.c:235:9: error: address argument to atomic
> > operation must be a pointer to non-const _Atomic type ('const atomic_int *'
> > (aka 'const _Atomic(int) *') invalid) if (atomic_load(&ft->ret))
> >         ^           ~~~~~~~~
> 
> That is a known bug in the Clang compiler that was fixed in newer versions, 
> AFAIK. You seem to be using something ancient...

I have many versions of clang on that box and several newer. But you are correct
and i intend to update that. Its just that updating the OS will break some scripts
and i need time to fix that, time ATM is limited.
As a sideeffect we get more testing with ancient clang which has its advanatges
too

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Homeopathy is like voting while filling the ballot out with transparent ink.
Sometimes the outcome one wanted occurs. Rarely its worse than filling out
a ballot properly.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".