From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 318C446CE0 for ; Sat, 8 Jul 2023 22:51:35 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 344D568C5A2; Sun, 9 Jul 2023 01:51:33 +0300 (EEST) Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [217.70.183.196]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3DD4268BF1A for ; Sun, 9 Jul 2023 01:51:26 +0300 (EEST) X-GND-Sasl: michael@niedermayer.cc Received: by mail.gandi.net (Postfix) with ESMTPSA id 918E3E0002 for ; Sat, 8 Jul 2023 22:51:25 +0000 (UTC) Date: Sun, 9 Jul 2023 00:51:24 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20230708225124.GD1093384@pb2> References: <20230707094847.25324-1-anton@khirnov.net> <20230707094847.25324-13-anton@khirnov.net> MIME-Version: 1.0 In-Reply-To: <20230707094847.25324-13-anton@khirnov.net> Subject: Re: [FFmpeg-devel] [PATCH 13/22] fftools/ffmpeg_filter: stop disregarding user-specified pixel format X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============0739981390878497309==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============0739981390878497309== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="fkwCrey//1f/3EP1" Content-Disposition: inline --fkwCrey//1f/3EP1 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jul 07, 2023 at 11:48:38AM +0200, Anton Khirnov wrote: > When the user explicitly specifies a pixel format that is not supported > by the encoder, ffmpeg CLI will currently use some heuristics to pick > another supported format. This is wrong and the correct action here is > to fail. >=20 > Surprisingly, a number of FATE tests are affected by this and actually > use a different pixel format than is specified in the makefiles. > --- > fftools/ffmpeg_filter.c | 36 ++----------------- > tests/fate/fits.mak | 6 ++-- > tests/fate/lavf-video.mak | 2 +- > tests/fate/vcodec.mak | 4 +-- > .../{fitsdec-gbrap16le =3D> fitsdec-gbrap16be} | 4 +-- > .../fate/{fitsdec-gbrp16 =3D> fitsdec-gbrp16be} | 4 +-- > tests/ref/lavf/gif | 2 +- > 7 files changed, 13 insertions(+), 45 deletions(-) > rename tests/ref/fate/{fitsdec-gbrap16le =3D> fitsdec-gbrap16be} (79%) > rename tests/ref/fate/{fitsdec-gbrp16 =3D> fitsdec-gbrp16be} (79%) This also seems to break the user interface and seems to violates what is d= ocumented: (unless iam too tired and mix something up here) @item -pix_fmt[:@var{stream_specifier}] @var{format} (@emph{input/output,pe= r-stream}) Set pixel format. Use @code{-pix_fmts} to show all the supported pixel formats. If the selected pixel format can not be selected, ffmpeg will print a warning and select the best pixel format supported by the encoder. If @var{pix_fmt} is prefixed by a @code{+}, ffmpeg will exit with an error if the requested pixel format can not be selected, and automatic conversions inside filtergraphs are disabled. If @var{pix_fmt} is a single @code{+}, ffmpeg selects the same pixel format as the input (or graph output) and automatic conversions are disabled. [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Take away the freedom of one citizen and you will be jailed, take away the freedom of all citizens and you will be congratulated by your peers in Parliament. --fkwCrey//1f/3EP1 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZKnoaAAKCRBhHseHBAsP q5j4AJ0TZ3+N01CfS+6T+VUootUA+u+YHwCfcGpZfsvGT/v0vjLmewlm06DQ16k= =jCe9 -----END PGP SIGNATURE----- --fkwCrey//1f/3EP1-- --===============0739981390878497309== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============0739981390878497309==--