From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id BC89746714 for ; Sat, 8 Jul 2023 22:15:41 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3477668C59E; Sun, 9 Jul 2023 01:15:39 +0300 (EEST) Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 69C2F68C4C5 for ; Sun, 9 Jul 2023 01:15:32 +0300 (EEST) X-GND-Sasl: michael@niedermayer.cc Received: by mail.gandi.net (Postfix) with ESMTPSA id C0CDF20005 for ; Sat, 8 Jul 2023 22:15:31 +0000 (UTC) Date: Sun, 9 Jul 2023 00:15:30 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20230708221530.GC1093384@pb2> References: <20230707094847.25324-1-anton@khirnov.net> <20230707094847.25324-13-anton@khirnov.net> MIME-Version: 1.0 In-Reply-To: <20230707094847.25324-13-anton@khirnov.net> Subject: Re: [FFmpeg-devel] [PATCH 13/22] fftools/ffmpeg_filter: stop disregarding user-specified pixel format X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============3759109373522643757==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============3759109373522643757== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="+b2GFy/wpzNn/yIF" Content-Disposition: inline --+b2GFy/wpzNn/yIF Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jul 07, 2023 at 11:48:38AM +0200, Anton Khirnov wrote: > When the user explicitly specifies a pixel format that is not supported > by the encoder, ffmpeg CLI will currently use some heuristics to pick > another supported format. This is wrong and the correct action here is > to fail. >=20 > Surprisingly, a number of FATE tests are affected by this and actually > use a different pixel format than is specified in the makefiles. > --- > fftools/ffmpeg_filter.c | 36 ++----------------- > tests/fate/fits.mak | 6 ++-- > tests/fate/lavf-video.mak | 2 +- > tests/fate/vcodec.mak | 4 +-- > .../{fitsdec-gbrap16le =3D> fitsdec-gbrap16be} | 4 +-- > .../fate/{fitsdec-gbrp16 =3D> fitsdec-gbrp16be} | 4 +-- > tests/ref/lavf/gif | 2 +- > 7 files changed, 13 insertions(+), 45 deletions(-) > rename tests/ref/fate/{fitsdec-gbrap16le =3D> fitsdec-gbrap16be} (79%) > rename tests/ref/fate/{fitsdec-gbrp16 =3D> fitsdec-gbrp16be} (79%) breaks png =2E/ffmpeg -y -i lena.pnm -s 696x300 -pix_fmt rgb48 -y out2.png Error while opening encoder - maybe incorrect parameters such as bit_rate, = rate, width or height. Conversion failed! before =2E/ffprobe out2.png =2E.. Stream #0:0: Video: png, rgb48be(pc, gbr/unknown/unknown), 696x300, 25 fps,= 25 tbr, 25 tbn Yes internally its BE vs LE but thats not what the user wrote on the comman= d line thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Republics decline into democracies and democracies degenerate into despotisms. -- Aristotle --+b2GFy/wpzNn/yIF Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZKnf+gAKCRBhHseHBAsP q2zaAJ9Tm1iPfLBMa9goU1lL0KoCsa43HgCfRh48bVvWUbenPjT0rUJjT+c1r9w= =dRE4 -----END PGP SIGNATURE----- --+b2GFy/wpzNn/yIF-- --===============3759109373522643757== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============3759109373522643757==--