From: Michael Niedermayer <michael@niedermayer.cc> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Subject: [FFmpeg-devel] [PATCH 10/18] avradio/sdr: eliminate avpriv_* Date: Sat, 8 Jul 2023 23:25:22 +0200 Message-ID: <20230708212530.109692-10-michael@niedermayer.cc> (raw) In-Reply-To: <20230708212530.109692-1-michael@niedermayer.cc> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> --- libavradio/sdr.h | 14 +++++++------- libavradio/sdrdemux.c | 32 ++++++++++++++++---------------- libavradio/sdrinradio.c | 14 +++++++------- 3 files changed, 30 insertions(+), 30 deletions(-) diff --git a/libavradio/sdr.h b/libavradio/sdr.h index 13237707b3..2940ffa389 100644 --- a/libavradio/sdr.h +++ b/libavradio/sdr.h @@ -228,7 +228,7 @@ typedef struct BandDescriptor { int64_t freq_max; } BandDescriptor ; -extern const AVOption avpriv_sdr_options[]; +extern const AVOption ff_sdr_options[]; extern ModulationDescriptor ff_sdr_modulation_descs[]; @@ -237,21 +237,21 @@ extern ModulationDescriptor ff_sdr_modulation_descs[]; * this will check the argument and call set_frequency_callback() * It can be called before the thread is started or from within the thread, */ -int avpriv_sdr_set_freq(SDRContext *sdr, int64_t freq); +int ff_sdr_set_freq(SDRContext *sdr, int64_t freq); -int avpriv_sdr_common_init(AVFormatContext *s); +int ff_sdr_common_init(AVFormatContext *s); -int avpriv_sdr_read_packet(AVFormatContext *s, AVPacket *pkt); +int ff_sdr_read_packet(AVFormatContext *s, AVPacket *pkt); -int avpriv_sdr_read_seek(AVFormatContext *s, int stream_index, int64_t target, int flags); +int ff_sdr_read_seek(AVFormatContext *s, int stream_index, int64_t target, int flags); /** * shuts down threads, destroys mutex * Safe to call if no thread was started or after it was shutdown */ -void avpriv_sdr_stop_threading(AVFormatContext *s); +void ff_sdr_stop_threading(AVFormatContext *s); -int avpriv_sdr_read_close(AVFormatContext *s); +int ff_sdr_read_close(AVFormatContext *s); int ff_sdr_vissualization(SDRContext *sdr, AVStream *st, AVPacket *pkt); diff --git a/libavradio/sdrdemux.c b/libavradio/sdrdemux.c index 6682768461..2bce1045f4 100644 --- a/libavradio/sdrdemux.c +++ b/libavradio/sdrdemux.c @@ -1056,7 +1056,7 @@ ModulationDescriptor ff_sdr_modulation_descs[] = { {"Frequency Modulation", "FM", FM, AVMEDIA_TYPE_AUDIO, probe_fm, demodulate_fm}, }; -int avpriv_sdr_set_freq(SDRContext *sdr, int64_t freq) +int ff_sdr_set_freq(SDRContext *sdr, int64_t freq) { freq = av_clip64(freq, sdr->min_center_freq, sdr->max_center_freq); @@ -1390,9 +1390,9 @@ static void *soapy_needs_bigger_buffers_worker(SDRContext *sdr) } if (sdr->wanted_freq != sdr->freq) { //We could use a seperate MUTEX for the FIFO and for soapy - avpriv_sdr_set_freq(sdr, sdr->wanted_freq); + ff_sdr_set_freq(sdr, sdr->wanted_freq); //This shouldnt really cause any problem if we just continue on error except that we continue returning data with the previous target frequency range - //And theres not much else we can do, an error message was already printed by avpriv_sdr_set_freq() in that case + //And theres not much else we can do, an error message was already printed by ff_sdr_set_freq() in that case block_counter = 0; // we just changed the frequency, do not trust the next blocks content } pthread_mutex_unlock(&sdr->mutex); @@ -1416,7 +1416,7 @@ static void *soapy_needs_bigger_buffers_worker(SDRContext *sdr) return NULL; } -int avpriv_sdr_common_init(AVFormatContext *s) +int ff_sdr_common_init(AVFormatContext *s) { SDRContext *sdr = s->priv_data; AVStream *st; @@ -1588,16 +1588,16 @@ static int sdrfile_initial_setup(AVFormatContext *s) //After reading the first packet header we return to the begin so the packet can be read whole avio_seek(s->pb, 0, SEEK_SET); - ret = avpriv_sdr_set_freq(sdr, sdr->wanted_freq); + ret = ff_sdr_set_freq(sdr, sdr->wanted_freq); if (ret < 0) return ret; sdr->read_callback = sdrfile_read_callback; - return avpriv_sdr_common_init(s); + return ff_sdr_common_init(s); } -int avpriv_sdr_read_packet(AVFormatContext *s, AVPacket *pkt) +int ff_sdr_read_packet(AVFormatContext *s, AVPacket *pkt) { SDRContext *sdr = s->priv_data; int ret, i, full_blocks, seek_direction; @@ -1860,7 +1860,7 @@ process_next_block: return AVERROR(EAGAIN); } -int avpriv_sdr_read_seek(AVFormatContext *s, int stream_index, +int ff_sdr_read_seek(AVFormatContext *s, int stream_index, int64_t target, int flags) { SDRContext *sdr = s->priv_data; @@ -1900,7 +1900,7 @@ int avpriv_sdr_read_seek(AVFormatContext *s, int stream_index, return 0; } -void avpriv_sdr_stop_threading(AVFormatContext *s) +void ff_sdr_stop_threading(AVFormatContext *s) { SDRContext *sdr = s->priv_data; @@ -1919,12 +1919,12 @@ void avpriv_sdr_stop_threading(AVFormatContext *s) sdr->thread_started = 0; } -int avpriv_sdr_read_close(AVFormatContext *s) +int ff_sdr_read_close(AVFormatContext *s) { SDRContext *sdr = s->priv_data; int i; - avpriv_sdr_stop_threading(s); + ff_sdr_stop_threading(s); av_fifo_freep2(&sdr->empty_block_fifo); av_fifo_freep2(&sdr->full_block_fifo); @@ -1969,7 +1969,7 @@ static int sdrfile_probe(const AVProbeData *p) #define OFFSET(x) offsetof(SDRContext, x) #define DEC AV_OPT_FLAG_DECODING_PARAM -const AVOption avpriv_sdr_options[] = { +const AVOption ff_sdr_options[] = { { "video_size", "set frame size", OFFSET(width), AV_OPT_TYPE_IMAGE_SIZE, {.str = "0x0"}, 0, 0, DEC }, { "framerate" , "set frame rate", OFFSET(fps), AV_OPT_TYPE_VIDEO_RATE, {.str = "25"}, 0, INT_MAX,DEC }, { "block_size", "FFT block size", OFFSET(block_size), AV_OPT_TYPE_INT, {.i64 = 0}, 0, INT_MAX, DEC}, @@ -2015,7 +2015,7 @@ const AVOption avpriv_sdr_options[] = { static const AVClass sdrfile_demuxer_class = { .class_name = "sdrfile", .item_name = av_default_item_name, - .option = avpriv_sdr_options, + .option = ff_sdr_options, .version = LIBAVUTIL_VERSION_INT, .category = AV_CLASS_CATEGORY_DEMUXER, }; @@ -2026,9 +2026,9 @@ const AVInputFormat ff_sdrfile_demuxer = { .priv_data_size = sizeof(SDRContext), .read_probe = sdrfile_probe, .read_header = sdrfile_initial_setup, - .read_packet = avpriv_sdr_read_packet, - .read_close = avpriv_sdr_read_close, - .read_seek = avpriv_sdr_read_seek, + .read_packet = ff_sdr_read_packet, + .read_close = ff_sdr_read_close, + .read_seek = ff_sdr_read_seek, .flags_internal = FF_FMT_INIT_CLEANUP, .priv_class = &sdrfile_demuxer_class, }; diff --git a/libavradio/sdrinradio.c b/libavradio/sdrinradio.c index af87b49495..0e7442fddf 100644 --- a/libavradio/sdrinradio.c +++ b/libavradio/sdrinradio.c @@ -272,7 +272,7 @@ static int sdrindev_initial_hw_setup(AVFormatContext *s) av_log(s, AV_LOG_ERROR, "setSampleRate fail: %s\n", SoapySDRDevice_lastError()); return AVERROR_EXTERNAL; } - ret = avpriv_sdr_set_freq(sdr, sdr->wanted_freq); + ret = ff_sdr_set_freq(sdr, sdr->wanted_freq); if (ret < 0) return ret; @@ -331,7 +331,7 @@ static int sdrindev_initial_hw_setup(AVFormatContext *s) SoapySDRDevice_activateStream(soapy, soapyRxStream, 0, 0, 0); - return avpriv_sdr_common_init(s); + return ff_sdr_common_init(s); } static int sdrindev_read_close(AVFormatContext *s) @@ -339,7 +339,7 @@ static int sdrindev_read_close(AVFormatContext *s) SDRContext *sdr = s->priv_data; SoapySDRDevice *soapy = sdr->soapy; - avpriv_sdr_stop_threading(s); + ff_sdr_stop_threading(s); if (soapy) { if (sdr->soapyRxStream) { @@ -352,7 +352,7 @@ static int sdrindev_read_close(AVFormatContext *s) sdr->soapy = NULL; } - return avpriv_sdr_read_close(s); + return ff_sdr_read_close(s); } static int sdr_get_device_list(AVFormatContext *ctx, AVDeviceInfoList *device_list) @@ -402,7 +402,7 @@ static int sdr_get_device_list(AVFormatContext *ctx, AVDeviceInfoList *device_li static const AVClass sdr_demuxer_class = { .class_name = "sdr", .item_name = av_default_item_name, - .option = avpriv_sdr_options, + .option = ff_sdr_options, .version = LIBAVUTIL_VERSION_INT, .category = AV_CLASS_CATEGORY_RADIO_INPUT, }; @@ -412,9 +412,9 @@ const AVInputFormat ff_sdr_demuxer = { .long_name = NULL_IF_CONFIG_SMALL("Software Defined Radio Demodulator"), .priv_data_size = sizeof(SDRContext), .read_header = sdrindev_initial_hw_setup, - .read_packet = avpriv_sdr_read_packet, + .read_packet = ff_sdr_read_packet, .read_close = sdrindev_read_close, - .read_seek = avpriv_sdr_read_seek, + .read_seek = ff_sdr_read_seek, .get_device_list= sdr_get_device_list, .flags = AVFMT_NOFILE, .flags_internal = FF_FMT_INIT_CLEANUP, -- 2.31.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-07-08 21:27 UTC|newest] Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-07-08 21:25 [FFmpeg-devel] [PATCH 01/18] avradio/sdrdemux: Fix uninitialized access Michael Niedermayer 2023-07-08 21:25 ` [FFmpeg-devel] [PATCH 02/18] avradio/sdrdemux: factor frequency tolerance constants out Michael Niedermayer 2023-07-08 21:25 ` [FFmpeg-devel] [PATCH 03/18] avradio/sdr: Add fm multiple parameter Michael Niedermayer 2023-07-08 21:25 ` [FFmpeg-devel] [PATCH 04/18] avradio/sdrinradio: Dont automatically select 2.56Mhz on the rtlsdr Michael Niedermayer 2023-07-08 21:25 ` [FFmpeg-devel] [PATCH 05/18] avradio/sdrdemux: Do not timeout negative stations Michael Niedermayer 2023-07-08 21:25 ` [FFmpeg-devel] [PATCH 06/18] avradio/sdrinradio: Factor print_and_free_list() out Michael Niedermayer 2023-07-08 21:25 ` [FFmpeg-devel] [PATCH 07/18] avradio/sdrinradio: Print list of Time Sources Michael Niedermayer 2023-07-08 21:25 ` [FFmpeg-devel] [PATCH 08/18] avradio: split out vissualization code Michael Niedermayer 2023-07-08 21:25 ` [FFmpeg-devel] [PATCH 09/18] avradio/sdrdemux: The RTLSDR DC artifact is not consistent Michael Niedermayer 2023-07-08 21:25 ` Michael Niedermayer [this message] 2023-07-08 21:25 ` [FFmpeg-devel] [PATCH 11/18] avradio/vissualize: rotate waterfall Michael Niedermayer 2023-07-08 21:25 ` [FFmpeg-devel] [PATCH 12/18] avradio/sdrdemux: Set AVFMTCTX_NOHEADER Michael Niedermayer 2023-07-08 21:25 ` [FFmpeg-devel] [PATCH 13/18] avradio/sdrdemux: fix bug adding candidate stations and then crashing Michael Niedermayer 2023-07-08 21:25 ` [FFmpeg-devel] [PATCH 14/18] avradio/sdrdemux: fm_probe: dont allow bandwidh=sample rate Michael Niedermayer 2023-07-08 21:25 ` [FFmpeg-devel] [PATCH 15/18] doc: add sdr examples Michael Niedermayer 2023-07-08 21:25 ` [FFmpeg-devel] [PATCH 16/18] avradio/sdr: rename fft_p2 Michael Niedermayer 2023-07-08 21:25 ` [FFmpeg-devel] [PATCH 17/18] avradio/sdrdemux: more correct phase 2 bandwidth of FM demodulation Michael Niedermayer 2023-07-08 21:25 ` [FFmpeg-devel] [PATCH 18/18] avradio/sdrdemux: Fix DC offset issue in AM demodulation Michael Niedermayer 2023-07-09 23:43 ` [FFmpeg-devel] [PATCH 01/18] avradio/sdrdemux: Fix uninitialized access Michael Niedermayer
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230708212530.109692-10-michael@niedermayer.cc \ --to=michael@niedermayer.cc \ --cc=ffmpeg-devel@ffmpeg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git