From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: [FFmpeg-devel] [PATCH 2/9] avradio/sdr: Consolidate candidate station entries
Date: Fri, 7 Jul 2023 19:22:17 +0200
Message-ID: <20230707172224.2368067-2-michael@niedermayer.cc> (raw)
In-Reply-To: <20230707172224.2368067-1-michael@niedermayer.cc>
also average frequcnies in candiddate station detections
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
---
libavradio/sdr.h | 1 +
libavradio/sdrdemux.c | 45 ++++++++++++++++++++++++++++++++++++-------
2 files changed, 39 insertions(+), 7 deletions(-)
diff --git a/libavradio/sdr.h b/libavradio/sdr.h
index 4d6887a296..29465df0a1 100644
--- a/libavradio/sdr.h
+++ b/libavradio/sdr.h
@@ -70,6 +70,7 @@ typedef struct Station {
char *name;
enum Modulation modulation;
double frequency;
+ int nb_frequency; ///< number of detections which are used to compute the frequency
int64_t bandwidth;
int64_t bandwidth_p2;
float score;
diff --git a/libavradio/sdrdemux.c b/libavradio/sdrdemux.c
index 4ac360f71b..41eda615ae 100644
--- a/libavradio/sdrdemux.c
+++ b/libavradio/sdrdemux.c
@@ -150,6 +150,12 @@ static int find_station_enu(void *opaque, void *elem)
return 0;
}
+static int free_station_enu(void *opaque, void *elem)
+{
+ free_station(elem);
+ return 0;
+}
+
/**
* Find stations within the given parameters.
* @param[out] station_list array to return stations in
@@ -218,15 +224,16 @@ static int create_station(SDRContext *sdr, Station *candidate_station) {
Station *station_list[1000];
int nb_stations = find_stations(sdr, sdr->block_center_freq, sdr->sdr_sample_rate*0.5, station_list, FF_ARRAY_ELEMS(station_list));
+ nb_candidate_match += candidate_station->nb_frequency - 1;
for (i=0; i<nb_stations; i++) {
int freq_precission = modulation == AM ? 5 : 50;
double delta = fabs(station_list[i]->frequency - freq);
// Station already added, or we have 2 rather close stations
if (modulation == station_list[i]->modulation && delta < freq_precission && station_list[i] != candidate_station) {
- nb_candidate_match++;
+ nb_candidate_match += station_list[i]->nb_frequency;
}
if (modulation != station_list[i]->modulation && delta < (bandwidth + station_list[i]->bandwidth)/2.1)
- nb_candidate_conflict++;
+ nb_candidate_conflict += station_list[i]->nb_frequency;
}
//if we have a recent conflict with an established station, skip this one
if (conflict < CANDIDATE_STATION_TIMEOUT)
@@ -355,20 +362,41 @@ static int create_candidate_station(SDRContext *sdr, enum Modulation modulation,
Station *station;
void *tmp;
struct AVTreeNode *next = NULL;
+ Station *station_list[1000];
+ double snapdistance = modulation == AM ? 5 : 50;
+ int nb_stations = find_stations(sdr, freq, snapdistance, station_list, FF_ARRAY_ELEMS(station_list));
+
+ if (nb_stations) {
+ for(int i = 1; i<nb_stations; i++)
+ if (station_list[0]->modulation != modulation ||
+ (station_list[i]->modulation == modulation &&
+ fabs(station_list[0]->frequency - freq) > fabs(station_list[i]->frequency - freq)))
+ station_list[0] = station_list[i];
+ nb_stations = station_list[0]->modulation == modulation;
+ }
- station = av_mallocz(sizeof(*station));
- if (!station)
- return AVERROR(ENOMEM);
+ if (!nb_stations) {
+ station = av_mallocz(sizeof(*station));
+ if (!station)
+ return AVERROR(ENOMEM);
+ station->frequency = freq;
+ } else {
+ station = station_list[0];
+ // We will update the frequency so we need to reinsert
+ tree_remove(&sdr->station_root, station, station_cmp, &next);
+ station->frequency = station->nb_frequency * station->frequency + freq;
+ station->timeout = 0;
+ }
+ station->frequency /= ++station->nb_frequency;
station->modulation = modulation;
- station->frequency = freq;
station->bandwidth = bandwidth;
station->bandwidth_p2 = bandwidth_p2;
station->score = score;
tmp = tree_insert(&sdr->station_root, station, station_cmp, &next);
if (tmp && tmp != station) {
- //unlikely
+ //This will not happen in real C implementations but floats allow odd things in theory
av_freep(&station);
}
av_freep(&next);
@@ -2025,6 +2053,9 @@ int avpriv_sdr_read_close(AVFormatContext *s)
}
sdr->nb_stations = 0;
av_freep(&sdr->station);
+ av_tree_enumerate(sdr->station_root, NULL, NULL, free_station_enu);
+ av_tree_destroy(sdr->station_root);
+ sdr->station_root = NULL;
av_freep(&sdr->windowed_block);
av_freep(&sdr->block);
--
2.31.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-07-07 17:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-07 17:22 [FFmpeg-devel] [PATCH 1/9] avradio/sdr: use AVTree for candidate stations Michael Niedermayer
2023-07-07 17:22 ` Michael Niedermayer [this message]
2023-07-07 17:22 ` [FFmpeg-devel] [PATCH 3/9] avradio/sdr: consolidate the candidate station list with the main list Michael Niedermayer
2023-07-07 17:22 ` [FFmpeg-devel] [PATCH 4/9] avradio/sdr: Eliminate station list Michael Niedermayer
2023-07-07 17:22 ` [FFmpeg-devel] [PATCH 5/9] avradio/sdr: Allow user to adjust FM/AM thresholds Michael Niedermayer
2023-07-07 17:22 ` [FFmpeg-devel] [PATCH 6/9] avradio/sdrdemux: count timeout irrespective of a station being active Michael Niedermayer
2023-07-07 17:22 ` [FFmpeg-devel] [PATCH 7/9] avradio/sdr: Compute and use detection histogram Michael Niedermayer
2023-07-07 17:22 ` [FFmpeg-devel] [PATCH 8/9] avradio/sdrdemux: increase the FM station frequency tolerance Michael Niedermayer
2023-07-07 17:22 ` [FFmpeg-devel] [PATCH 9/9] avradio/sdrdemux: Use 2 differnt FM station detectors Michael Niedermayer
2023-07-08 15:42 ` [FFmpeg-devel] [PATCH 1/9] avradio/sdr: use AVTree for candidate stations Michael Niedermayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230707172224.2368067-2-michael@niedermayer.cc \
--to=michael@niedermayer.cc \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git