From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id CA4FA46CBD for ; Fri, 7 Jul 2023 13:46:15 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 258AF68C71D; Fri, 7 Jul 2023 16:46:12 +0300 (EEST) Received: from btbn.de (btbn.de [136.243.74.85]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6318A68C3EF for ; Fri, 7 Jul 2023 16:46:05 +0300 (EEST) Received: from [authenticated] by btbn.de (Postfix) with ESMTPSA id B518A4BA42; Fri, 7 Jul 2023 15:46:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rothenpieler.org; s=mail; t=1688737562; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=6fbTNGfJAex4kc5SP7Y0ONF2TAq3m4WEEiyWck54des=; b=bbSssR7puZIunf+fn25Ni1TwykurgZJRglwec4gzrDk/4TUSEOufXOoEbbmtZsKjs2v/Mn dvXeUVROlyw41bA1j/s7fdEP897Xpkly8NIGSzBk3qxqlryhKYdry3cKlqf8PVaZHMGBnx 0Sjg1MaACD15JhO13Ovu5viZ6ZJOqqVXVHXzHB8UVt1mwlePQ75IN6vpUXody/t2tsZ0hA PTAfWkJoOb00DDKMlX8dg/bfmjCzNWCey6T2H7wgRX5MZaXxbtgv6VyMiypmEcHYUhONgl jaA2p5MuHNb89IOKlaJ/6ZwgFBHnkTW0u88AufmfwgFb3gJJledTi3OtpSrmww== From: Timo Rothenpieler To: ffmpeg-devel@ffmpeg.org Date: Fri, 7 Jul 2023 15:45:53 +0200 Message-Id: <20230707134553.13643-1-timo@rothenpieler.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH] avfilter/vf_vidstabdetect: force ASCII mode if possible X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Timo Rothenpieler Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Newer versions of the library added a new binary output format, and prefer using it by default. Those binary files seem to cause issues for a lot of users, where ffmpeg fails to (sometimes?) read back the trf file it has just written itself. My guess is that this might be because of the fopen-mode of "w" below, where "wb" would be needed. But since we can't really know what format the library is about to write, it's better to force it into ASCII mode when possible. --- libavfilter/vf_vidstabdetect.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/libavfilter/vf_vidstabdetect.c b/libavfilter/vf_vidstabdetect.c index b27b1e40a6..7170f56f81 100644 --- a/libavfilter/vf_vidstabdetect.c +++ b/libavfilter/vf_vidstabdetect.c @@ -110,6 +110,10 @@ static int config_input(AVFilterLink *inlink) return AVERROR(EINVAL); } +#ifdef ASCII_SERIALIZATION_MODE + md->serializationMode = ASCII_SERIALIZATION_MODE; +#endif + // set values that are not initialized by the options s->conf.algo = 1; s->conf.modName = "vidstabdetect"; -- 2.34.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".