Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
* [FFmpeg-devel] [PATCH] avfilter/vf_vidstabdetect: force ASCII mode if possible
@ 2023-07-07 13:45 Timo Rothenpieler
  0 siblings, 0 replies; only message in thread
From: Timo Rothenpieler @ 2023-07-07 13:45 UTC (permalink / raw)
  To: ffmpeg-devel; +Cc: Timo Rothenpieler

Newer versions of the library added a new binary output format, and prefer using it by default.
Those binary files seem to cause issues for a lot of users, where ffmpeg fails to (sometimes?) read
back the trf file it has just written itself.

My guess is that this might be because of the fopen-mode of "w" below, where "wb" would be needed.
But since we can't really know what format the library is about to write, it's better to force
it into ASCII mode when possible.
---
 libavfilter/vf_vidstabdetect.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/libavfilter/vf_vidstabdetect.c b/libavfilter/vf_vidstabdetect.c
index b27b1e40a6..7170f56f81 100644
--- a/libavfilter/vf_vidstabdetect.c
+++ b/libavfilter/vf_vidstabdetect.c
@@ -110,6 +110,10 @@ static int config_input(AVFilterLink *inlink)
         return AVERROR(EINVAL);
     }
 
+#ifdef ASCII_SERIALIZATION_MODE
+    md->serializationMode = ASCII_SERIALIZATION_MODE;
+#endif
+
     // set values that are not initialized by the options
     s->conf.algo     = 1;
     s->conf.modName  = "vidstabdetect";
-- 
2.34.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-07-07 13:46 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-07 13:45 [FFmpeg-devel] [PATCH] avfilter/vf_vidstabdetect: force ASCII mode if possible Timo Rothenpieler

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git