From: Timo Rothenpieler <timo@rothenpieler.org> To: ffmpeg-devel@ffmpeg.org Cc: Timo Rothenpieler <timo@rothenpieler.org> Subject: [FFmpeg-devel] [PATCH] avfilter/vf_vidstabdetect: force ASCII mode if possible Date: Fri, 7 Jul 2023 15:45:53 +0200 Message-ID: <20230707134553.13643-1-timo@rothenpieler.org> (raw) Newer versions of the library added a new binary output format, and prefer using it by default. Those binary files seem to cause issues for a lot of users, where ffmpeg fails to (sometimes?) read back the trf file it has just written itself. My guess is that this might be because of the fopen-mode of "w" below, where "wb" would be needed. But since we can't really know what format the library is about to write, it's better to force it into ASCII mode when possible. --- libavfilter/vf_vidstabdetect.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/libavfilter/vf_vidstabdetect.c b/libavfilter/vf_vidstabdetect.c index b27b1e40a6..7170f56f81 100644 --- a/libavfilter/vf_vidstabdetect.c +++ b/libavfilter/vf_vidstabdetect.c @@ -110,6 +110,10 @@ static int config_input(AVFilterLink *inlink) return AVERROR(EINVAL); } +#ifdef ASCII_SERIALIZATION_MODE + md->serializationMode = ASCII_SERIALIZATION_MODE; +#endif + // set values that are not initialized by the options s->conf.algo = 1; s->conf.modName = "vidstabdetect"; -- 2.34.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
reply other threads:[~2023-07-07 13:46 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230707134553.13643-1-timo@rothenpieler.org \ --to=timo@rothenpieler.org \ --cc=ffmpeg-devel@ffmpeg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git