From: Anton Khirnov <anton@khirnov.net>
To: ffmpeg-devel@ffmpeg.org
Subject: [FFmpeg-devel] [PATCH v2 06/10] lavc: move AVCodecInternal.last_audio_frame to EncodeContext
Date: Mon, 3 Jul 2023 21:32:25 +0200
Message-ID: <20230703193229.8593-7-anton@khirnov.net> (raw)
In-Reply-To: <20230703193229.8593-1-anton@khirnov.net>
It does not need to be visible outside of encode.c.
---
libavcodec/encode.c | 13 ++++++++++---
libavcodec/internal.h | 6 ------
2 files changed, 10 insertions(+), 9 deletions(-)
diff --git a/libavcodec/encode.c b/libavcodec/encode.c
index 6da5d86ea0..58eab5b001 100644
--- a/libavcodec/encode.c
+++ b/libavcodec/encode.c
@@ -42,6 +42,12 @@ typedef struct EncodeContext {
* This is used to set said flag generically for said encoders.
*/
int intra_only_flag;
+
+ /**
+ * An audio frame with less than required samples has been submitted (and
+ * potentially padded with silence). Reject all subsequent frames.
+ */
+ int last_audio_frame;
} EncodeContext;
static EncodeContext *encode_ctx(AVCodecInternal *avci)
@@ -174,7 +180,7 @@ static int pad_last_frame(AVCodecContext *s, AVFrame *frame, const AVFrame *src,
fail:
av_frame_unref(frame);
- s->internal->last_audio_frame = 0;
+ encode_ctx(s->internal)->last_audio_frame = 0;
return ret;
}
@@ -446,6 +452,7 @@ static int encode_generate_icc_profile(av_unused AVCodecContext *c, av_unused AV
static int encode_send_frame_internal(AVCodecContext *avctx, const AVFrame *src)
{
AVCodecInternal *avci = avctx->internal;
+ EncodeContext *ec = encode_ctx(avci);
AVFrame *dst = avci->buffer_frame;
int ret;
@@ -458,7 +465,7 @@ static int encode_send_frame_internal(AVCodecContext *avctx, const AVFrame *src)
/* check for valid frame size */
if (!(avctx->codec->capabilities & AV_CODEC_CAP_VARIABLE_FRAME_SIZE)) {
/* if we already got an undersized frame, that must have been the last */
- if (avctx->internal->last_audio_frame) {
+ if (ec->last_audio_frame) {
av_log(avctx, AV_LOG_ERROR, "frame_size (%d) was not respected for a non-last frame\n", avctx->frame_size);
return AVERROR(EINVAL);
}
@@ -467,7 +474,7 @@ static int encode_send_frame_internal(AVCodecContext *avctx, const AVFrame *src)
return AVERROR(EINVAL);
}
if (src->nb_samples < avctx->frame_size) {
- avctx->internal->last_audio_frame = 1;
+ ec->last_audio_frame = 1;
if (!(avctx->codec->capabilities & AV_CODEC_CAP_SMALL_LAST_FRAME)) {
int pad_samples = avci->pad_samples ? avci->pad_samples : avctx->frame_size;
int out_samples = (src->nb_samples + pad_samples - 1) / pad_samples * pad_samples;
diff --git a/libavcodec/internal.h b/libavcodec/internal.h
index 497cd77f23..868dd46b48 100644
--- a/libavcodec/internal.h
+++ b/libavcodec/internal.h
@@ -56,12 +56,6 @@ typedef struct AVCodecInternal {
*/
int is_copy;
- /**
- * An audio frame with less than required samples has been submitted (and
- * potentially padded with silence). Reject all subsequent frames.
- */
- int last_audio_frame;
-
/**
* Audio encoders can set this flag during init to indicate that they
* want the small last frame to be padded to a multiple of pad_samples.
--
2.40.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-07-03 19:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-03 19:32 [FFmpeg-devel] [PATCH v2 00/10] lavc generic-layer private data Anton Khirnov
2023-07-03 19:32 ` [FFmpeg-devel] [PATCH v2 01/10] lavc: add a header for internal generic-layer APIs Anton Khirnov
2023-07-03 19:32 ` [FFmpeg-devel] [PATCH v2 02/10] lavc/avcodec: split flushing into decode- and encode-specific functions Anton Khirnov
2023-07-03 19:32 ` [FFmpeg-devel] [PATCH v2 03/10] lavc: reindent after previous commit Anton Khirnov
2023-07-03 19:32 ` [FFmpeg-devel] [PATCH v2 04/10] lavc: add generic-decode-layer private data Anton Khirnov
2023-07-03 19:32 ` [FFmpeg-devel] [PATCH v2 05/10] lavc: add generic-encode-layer " Anton Khirnov
2023-07-03 19:32 ` Anton Khirnov [this message]
2023-07-03 19:32 ` [FFmpeg-devel] [PATCH v2 07/10] lavc/decode: track whether the caller started draining with a separate flag Anton Khirnov
2023-07-03 19:32 ` [FFmpeg-devel] [PATCH v2 08/10] lavc/bsf: move IS_EMPTY() to packet_internal() Anton Khirnov
2023-07-03 19:32 ` [FFmpeg-devel] [PATCH v2 09/10] lavc/decode: move submitting input packets to bitstream filters Anton Khirnov
2023-07-03 19:32 ` [FFmpeg-devel] [PATCH v2 10/10] lavc/decode: do not perform decoding when sending draining packets Anton Khirnov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230703193229.8593-7-anton@khirnov.net \
--to=anton@khirnov.net \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git