From: Anton Khirnov <anton@khirnov.net> To: ffmpeg-devel@ffmpeg.org Subject: [FFmpeg-devel] [PATCH v2 02/10] lavc/avcodec: split flushing into decode- and encode-specific functions Date: Mon, 3 Jul 2023 21:32:21 +0200 Message-ID: <20230703193229.8593-3-anton@khirnov.net> (raw) In-Reply-To: <20230703193229.8593-1-anton@khirnov.net> Will allow making some state private to encoding/decoding in the future. --- libavcodec/avcodec.c | 17 +++-------------- libavcodec/avcodec_internal.h | 3 +++ libavcodec/decode.c | 15 +++++++++++++++ libavcodec/encode.c | 10 ++++++++++ 4 files changed, 31 insertions(+), 14 deletions(-) diff --git a/libavcodec/avcodec.c b/libavcodec/avcodec.c index 638cb55146..c01dac2049 100644 --- a/libavcodec/avcodec.c +++ b/libavcodec/avcodec.c @@ -383,23 +383,12 @@ void avcodec_flush_buffers(AVCodecContext *avctx) "that doesn't support it\n"); return; } - if (avci->in_frame) - av_frame_unref(avci->in_frame); - if (avci->recon_frame) - av_frame_unref(avci->recon_frame); - } else { - av_packet_unref(avci->last_pkt_props); - av_packet_unref(avci->in_pkt); - - avctx->pts_correction_last_pts = - avctx->pts_correction_last_dts = INT64_MIN; - - av_bsf_flush(avci->bsf); - } + ff_encode_flush_buffers(avctx); + } else + ff_decode_flush_buffers(avctx); avci->draining = 0; avci->draining_done = 0; - avci->nb_draining_errors = 0; av_frame_unref(avci->buffer_frame); av_packet_unref(avci->buffer_pkt); diff --git a/libavcodec/avcodec_internal.h b/libavcodec/avcodec_internal.h index be60a36644..6ffe575c3e 100644 --- a/libavcodec/avcodec_internal.h +++ b/libavcodec/avcodec_internal.h @@ -50,4 +50,7 @@ int ff_encode_preinit(struct AVCodecContext *avctx); */ int ff_decode_preinit(struct AVCodecContext *avctx); +void ff_decode_flush_buffers(struct AVCodecContext *avctx); +void ff_encode_flush_buffers(struct AVCodecContext *avctx); + #endif // AVCODEC_AVCODEC_INTERNAL_H diff --git a/libavcodec/decode.c b/libavcodec/decode.c index 336635f772..01ac35bf34 100644 --- a/libavcodec/decode.c +++ b/libavcodec/decode.c @@ -1740,3 +1740,18 @@ AVBufferRef *ff_hwaccel_frame_priv_alloc(AVCodecContext *avctx, return ref; } + +void ff_decode_flush_buffers(AVCodecContext *avctx) +{ + AVCodecInternal *avci = avctx->internal; + + av_packet_unref(avci->last_pkt_props); + av_packet_unref(avci->in_pkt); + + avctx->pts_correction_last_pts = + avctx->pts_correction_last_dts = INT64_MIN; + + av_bsf_flush(avci->bsf); + + avci->nb_draining_errors = 0; +} diff --git a/libavcodec/encode.c b/libavcodec/encode.c index 3a016b14c1..0b1947c781 100644 --- a/libavcodec/encode.c +++ b/libavcodec/encode.c @@ -785,3 +785,13 @@ int ff_encode_receive_frame(AVCodecContext *avctx, AVFrame *frame) av_frame_move_ref(frame, avci->recon_frame); return 0; } + +void ff_encode_flush_buffers(AVCodecContext *avctx) +{ + AVCodecInternal *avci = avctx->internal; + + if (avci->in_frame) + av_frame_unref(avci->in_frame); + if (avci->recon_frame) + av_frame_unref(avci->recon_frame); +} -- 2.40.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-07-03 19:33 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-07-03 19:32 [FFmpeg-devel] [PATCH v2 00/10] lavc generic-layer private data Anton Khirnov 2023-07-03 19:32 ` [FFmpeg-devel] [PATCH v2 01/10] lavc: add a header for internal generic-layer APIs Anton Khirnov 2023-07-03 19:32 ` Anton Khirnov [this message] 2023-07-03 19:32 ` [FFmpeg-devel] [PATCH v2 03/10] lavc: reindent after previous commit Anton Khirnov 2023-07-03 19:32 ` [FFmpeg-devel] [PATCH v2 04/10] lavc: add generic-decode-layer private data Anton Khirnov 2023-07-03 19:32 ` [FFmpeg-devel] [PATCH v2 05/10] lavc: add generic-encode-layer " Anton Khirnov 2023-07-03 19:32 ` [FFmpeg-devel] [PATCH v2 06/10] lavc: move AVCodecInternal.last_audio_frame to EncodeContext Anton Khirnov 2023-07-03 19:32 ` [FFmpeg-devel] [PATCH v2 07/10] lavc/decode: track whether the caller started draining with a separate flag Anton Khirnov 2023-07-03 19:32 ` [FFmpeg-devel] [PATCH v2 08/10] lavc/bsf: move IS_EMPTY() to packet_internal() Anton Khirnov 2023-07-03 19:32 ` [FFmpeg-devel] [PATCH v2 09/10] lavc/decode: move submitting input packets to bitstream filters Anton Khirnov 2023-07-03 19:32 ` [FFmpeg-devel] [PATCH v2 10/10] lavc/decode: do not perform decoding when sending draining packets Anton Khirnov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230703193229.8593-3-anton@khirnov.net \ --to=anton@khirnov.net \ --cc=ffmpeg-devel@ffmpeg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git