From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 46BF346B2A for ; Mon, 3 Jul 2023 14:17:58 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B2E2568C55A; Mon, 3 Jul 2023 17:17:55 +0300 (EEST) Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [217.70.183.194]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E753A68C449 for ; Mon, 3 Jul 2023 17:17:49 +0300 (EEST) X-GND-Sasl: michael@niedermayer.cc Received: by mail.gandi.net (Postfix) with ESMTPSA id DBDDE4000C for ; Mon, 3 Jul 2023 14:17:48 +0000 (UTC) Date: Mon, 3 Jul 2023 16:17:47 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20230703141747.GP1093384@pb2> References: <20230703054753.GO1093384@pb2> MIME-Version: 1.0 In-Reply-To: Subject: Re: [FFmpeg-devel] [SDR][RFC] libavradio branch changes X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============9101493003353179547==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============9101493003353179547== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="6sj9mcRtP+pTWLOo" Content-Disposition: inline --6sj9mcRtP+pTWLOo Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jul 03, 2023 at 10:54:05AM +0200, Paul B Mahol wrote: > On Mon, Jul 3, 2023 at 7:48=E2=80=AFAM Michael Niedermayer > wrote: >=20 > > Hi > > > > the new libavradio in its new repository needs some changes the problem > > is that maintaining it in a separate repository AND seperate directory = is > > not > > so simple > > But let me show this in numbers, this is the stats of the changes relat= ed > > to the build > > system that would need to be maintained: > > > > commit e262fd4b85a1a3ddf34c365bb88e54cdc6be53eb > > Author: Michael Niedermayer > > Date: Sun Jul 2 14:08:42 2023 +0200 > > > > Move sdr to new libavradio > > > > Signed-off-by: Michael Niedermayer > > > > Makefile | 5 +-- > > configure | 36 > > ++++++++++++++++++++-- > > fftools/ffmpeg.c | 5 +++ > > fftools/ffplay.c | 4 +++ > > fftools/ffprobe.c | 4 +++ > > fftools/opt_common.c | 62 > > ++++++++++++++++++++++++++++++++++--- > > fftools/opt_common.h | 27 ++++++++++++++= ++ > > libavdevice/Makefile | 1 - > > libavdevice/alldevices.c | 1 - > > libavdevice/utils.c | 2 +- > > libavformat/allformats.c | 32 > > ++++++++++++++----- > > libavformat/internal.h | 1 + > > libavradio/Makefile | 14 +++++++++ > > libavradio/allradios.c | 65 > > +++++++++++++++++++++++++++++++++++++++ > > libavradio/avradio.c | 32 > > +++++++++++++++++++ > > libavradio/avradio.h | 121 > > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > libavradio/internal.h | 28 ++++++++++++++= +++ > > libavdevice/sdrindev.c =3D> libavradio/sdrinradio.c | 2 +- > > {libavdevice =3D> libavradio}/utils.c | 4 +-- > > libavradio/version.c | 45 > > +++++++++++++++++++++++++++ > > libavradio/version.h | 45 > > +++++++++++++++++++++++++++ > > libavradio/version_major.h | 36 > > ++++++++++++++++++++++ > > libavutil/log.h | 1 + > > tools/uncoded_frame.c | 4 +++ > > 24 files changed, 554 insertions(+), 23 deletions(-) > > > > > > > > I do not know if changes to the build system can be marged in git maste= r or > > if people agree to that at all. > > But if this needs to be maintained in its current form, it will cause b= ugs > > and alot of extra work over time > > > > the alternative would be to undo the libavradio thing and rather mainta= in > > sdr as input device and demuxer in the libavradio repository > > > > Of course having the sdr input device and file demuxer in git master wo= uld > > be the least amount of work > > >=20 > Everyone is against this, pushing for it will not make it happen. I think there where about 6 people who had varing levels of dislike to it. Probably a few more. Thats not everyone But i have not suggested that to be done now, i have not pushed for that at all in the text or mail above. Its just a statement of fact that it would be least work. That statement, that its least work, has not been disputed by anyone I mentioned this so people dont miss that the way its done now, has a cost to it. The 2 repository approuch costs additional time to maintain Also moving the whole libavradio to git master is not what this mail was intended to suggest at all. Thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Take away the freedom of one citizen and you will be jailed, take away the freedom of all citizens and you will be congratulated by your peers in Parliament. --6sj9mcRtP+pTWLOo Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZKLYhwAKCRBhHseHBAsP q67ZAJ9z6MG4BrJvpbvGXkLZ0emR8iIRIgCdGntfiqid81ElaO12RmmpWp8c1cM= =gdIQ -----END PGP SIGNATURE----- --6sj9mcRtP+pTWLOo-- --===============9101493003353179547== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============9101493003353179547==--