From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id AA9D4469E3 for ; Sat, 1 Jul 2023 20:06:48 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 678BC68C03F; Sat, 1 Jul 2023 23:06:45 +0300 (EEST) Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7FE0268BF94 for ; Sat, 1 Jul 2023 23:06:39 +0300 (EEST) X-GND-Sasl: michael@niedermayer.cc Received: by mail.gandi.net (Postfix) with ESMTPSA id 268A160002 for ; Sat, 1 Jul 2023 20:06:37 +0000 (UTC) Date: Sat, 1 Jul 2023 22:06:35 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20230701200635.GH1093384@pb2> References: <20230628212504.2522567-1-michael@niedermayer.cc> <20230630140838.GA1093384@pb2> <4f0dc1-fb9b-a532-05a-6e8e1debfe91@martin.st> <20230701144442.GD1093384@pb2> <2e90ba71-f56f-974d-d76d-a750c480c09c@martin.st> MIME-Version: 1.0 In-Reply-To: <2e90ba71-f56f-974d-d76d-a750c480c09c@martin.st> Subject: Re: [FFmpeg-devel] [PATCH v6 0/1] avformat: add Software Defined Radio support X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============6193677654804084351==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============6193677654804084351== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="LZFKeWUZP29EKQNE" Content-Disposition: inline --LZFKeWUZP29EKQNE Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Jul 01, 2023 at 10:41:34PM +0300, Martin Storsj=F6 wrote: > On Sat, 1 Jul 2023, Michael Niedermayer wrote: >=20 > > On Sat, Jul 01, 2023 at 12:36:06AM +0300, Martin Storsj=F6 wrote: > > > On Fri, 30 Jun 2023, Michael Niedermayer wrote: > > >=20 > > > > On Thu, Jun 29, 2023 at 05:43:53PM +0200, Paul B Mahol wrote: > > > > > If you apply this I will apply my pending libswresample commits a= nd also > > > > > remove sonic decoder from libavcodec. > > > >=20 > > > > ok, if you plan to fix the bugs in the libswresample patches > > > >=20 > > > > ill wait a bit, so others can object and if no objections will > > > > apply the current SDR patch with the probe function disabled. > > > > That ensures it will not be used without the user explicitly > > > > selecting it. > > >=20 > > > I object to merging this patch. > > >=20 > > > As numerous others have said already, this is at the wrong level of > > > abstraction, even if it happens to work for you for the current use c= ase. > > >=20 > > > Even if it is disabled by default, git master isn't a playground for > > > personal projects. > >=20 > > If you belive this is implemented at the wrong level, > > can you please elaborately explain the implementation which is > > in your oppinion at the correct level ? >=20 > As there are talks about receiving DAB/DVB from the same source, those wo= uld > definitely be on a different level than libavformat, since the output of > them would be an mpegts stream (or multiple), or whatever transport format > DAB uses. If i search for "mpegts" in libavformat i find hls, rtp, rtsp, segment, wtv but iam sure these arent the only mixed containers. If we look at DAB or DVB in a more fundamental way, they have no need for mpegts. Should this (apparently unneeded) design decission in DAB/DVB dictate design on our side when it has not previously ? If so, what design ? > As for purely AM/FM, I'm not quire sure what the right level for > that is though. > > In any case, I disagree with the procedure of stating to push the patch if > there's no objections, when there has been numerous objections from > essentially most of the active community already. The objections have been unclear, are they against SDR, against the implementation. I took the liberty to be pushy here to get this more clear. And i will continue to do this until i get clear responses. Because otherwise iam just stuck as i dont know how to correct the design and code. Thank you for clarifying the libavformat issue. [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Breaking DRM is a little like attempting to break through a door even though the window is wide open and the only thing in the house is a bunch of things you dont want and which you would get tomorrow for free anyway --LZFKeWUZP29EKQNE Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZKCHRwAKCRBhHseHBAsP q/y3AJoC51zC3jPdb703S/xG+ooXCfBQFQCffmgWnOpg1W8IwrdWT0RO5Fx5BTM= =LFKK -----END PGP SIGNATURE----- --LZFKeWUZP29EKQNE-- --===============6193677654804084351== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============6193677654804084351==--