On Fri, Jun 30, 2023 at 06:00:18PM +0100, Kieran Kunhya wrote: > On Fri, 30 Jun 2023 at 15:08, Michael Niedermayer > wrote: > > > On Thu, Jun 29, 2023 at 05:43:53PM +0200, Paul B Mahol wrote: > > > If you apply this I will apply my pending libswresample commits and also > > > remove sonic decoder from libavcodec. > > > > ok, if you plan to fix the bugs in the libswresample patches > > > > ill wait a bit, so others can object and if no objections will > > apply the current SDR patch with the probe function disabled. > > That ensures it will not be used without the user explicitly > > selecting it. > > > > There's clearly a substantial objection to you putting this main FFmpeg. yes, there is substantial objection to ME putting THIS in main FFmpeg. So someone else can ? Or this is a review of a submited patch ? It may seem a silly detail but lets keep this at a technical level and not slip towards people. So what really are the objection from reviewers about ? Me ? ill politely disregard these kind of objections SDR in general? Ill bring this to a vote if such objections remain. Iam just hesitant as i dont want to annoy people with votes unneccessarily If the community decides SDR is off limits for FFmpeg then this should be a universal decission. The specific implementation ? If so I again ask politely for as detailed as possible information on how the implementation should look. Also iam curious if the reviewer intends to use the SDR feature or if he wants to contribute Thank you [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB While the State exists there can be no freedom; when there is freedom there will be no State. -- Vladimir Lenin