Re: [FFmpeg-devel] [PATCH v6 0/1] avformat: add Software Defined Radio support

[Michael Niedermayer <michael@niedermayer.cc>]

[-- Attachment #1.1: Type: text/plain, Size: 1424 bytes --]

Hi Martin

On Sat, Jul 01, 2023 at 12:36:06AM +0300, Martin Storsjö wrote:
> On Fri, 30 Jun 2023, Michael Niedermayer wrote:
> 
> > On Thu, Jun 29, 2023 at 05:43:53PM +0200, Paul B Mahol wrote:
> > > If you apply this I will apply my pending libswresample commits and also
> > > remove sonic decoder from libavcodec.
> > 
> > ok, if you plan to fix the bugs in the libswresample patches
> > 
> > ill wait a bit, so others can object and if no objections will
> > apply the current SDR patch with the probe function disabled.
> > That ensures it will not be used without the user explicitly
> > selecting it.
> 
> I object to merging this patch.
> 
> As numerous others have said already, this is at the wrong level of
> abstraction, even if it happens to work for you for the current use case.
> 
> Even if it is disabled by default, git master isn't a playground for
> personal projects.

If you belive this is implemented at the wrong level,
can you please elaborately explain the implementation which is
in your oppinion at the correct level ?

Thank you

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The real ebay dictionary, page 1
"Used only once"    - "Some unspecified defect prevented a second use"
"In good condition" - "Can be repaird by experienced expert"
"As is" - "You wouldnt want it even if you were payed for it, if you knew ..."

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".