From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 0A36046910 for ; Sat, 24 Jun 2023 20:11:26 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id AE49B68C159; Sat, 24 Jun 2023 23:11:23 +0300 (EEST) Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [217.70.183.196]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2EF1768BF4D for ; Sat, 24 Jun 2023 23:11:18 +0300 (EEST) X-GND-Sasl: michael@niedermayer.cc Received: by mail.gandi.net (Postfix) with ESMTPSA id 68057E0002 for ; Sat, 24 Jun 2023 20:11:17 +0000 (UTC) Date: Sat, 24 Jun 2023 22:11:16 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20230624201116.GW3250409@pb2> References: <20230624171245.740-1-jamrial@gmail.com> MIME-Version: 1.0 In-Reply-To: <20230624171245.740-1-jamrial@gmail.com> Subject: Re: [FFmpeg-devel] [PATCH] avcodec/j2kenc: use uint64_t type for the lambda value X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============1511773571433901985==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============1511773571433901985== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="p609JBPwWeYlfsbE" Content-Disposition: inline --p609JBPwWeYlfsbE Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Jun 24, 2023 at 02:12:45PM -0300, James Almer wrote: > Should fix integer overflows, and improve encoding results. >=20 > Signed-off-by: James Almer > --- > libavcodec/j2kenc.c | 4 ++-- > tests/ref/vsynth/vsynth1-jpeg2000-yuva444p16 | 8 ++++---- > tests/ref/vsynth/vsynth2-jpeg2000-yuva444p16 | 8 ++++---- > tests/ref/vsynth/vsynth3-jpeg2000-yuva444p16 | 8 ++++---- > tests/ref/vsynth/vsynth_lena-jpeg2000-yuva444p16 | 8 ++++---- > 5 files changed, 18 insertions(+), 18 deletions(-) LGTM have you checked that unsigned 64bit will not overflow too ? thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Breaking DRM is a little like attempting to break through a door even though the window is wide open and the only thing in the house is a bunch of things you dont want and which you would get tomorrow for free anyway --p609JBPwWeYlfsbE Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZJdN5AAKCRBhHseHBAsP q3UyAJ9AJcvXAwgbRAmw5si/66PL+r7R8wCfQL8jYqe9+HLQ8pPAAMBKtDgtnVU= =SA+C -----END PGP SIGNATURE----- --p609JBPwWeYlfsbE-- --===============1511773571433901985== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============1511773571433901985==--