From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [RFC] SDR
Date: Thu, 22 Jun 2023 20:52:04 +0200
Message-ID: <20230622185204.GF3250409@pb2> (raw)
In-Reply-To: <20230622174311.GE3250409@pb2>
[-- Attachment #1.1: Type: text/plain, Size: 783 bytes --]
On Thu, Jun 22, 2023 at 07:43:11PM +0200, Michael Niedermayer wrote:
> On Thu, Jun 22, 2023 at 06:09:47PM +0200, Anton Khirnov wrote:
[...]
> > 3) sdr_read_header() and sdr_read_packet() are giant, hideous, and
> > unreadable.
>
> I disagree that they are hideous and unreadable. In fact its largely just
> setting up the hw in sdr_read_header() and thats very close to what the
> libsoapy example code does.
>
> But ill see if it can be split a bit.
Ill include some cleanup, comments and factorization in V3.
Please give me feedback if that is what you had in mind or if it was
something else
thx
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
He who knows, does not speak. He who speaks, does not know. -- Lao Tsu
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-06-22 18:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-22 14:57 Michael Niedermayer
2023-06-22 15:01 ` James Almer
2023-06-22 15:09 ` Thilo Borgmann
2023-06-22 16:09 ` Anton Khirnov
2023-06-22 17:43 ` Michael Niedermayer
2023-06-22 18:52 ` Michael Niedermayer [this message]
2023-06-23 11:26 ` James Almer
2023-06-23 20:18 ` Tomas Härdin
2023-06-23 20:19 ` Tomas Härdin
2023-06-23 21:36 ` Michael Niedermayer
2023-06-24 10:12 ` Tomas Härdin
2023-06-24 21:29 ` Michael Niedermayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230622185204.GF3250409@pb2 \
--to=michael@niedermayer.cc \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git