From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 3DBF746873 for ; Thu, 22 Jun 2023 16:26:35 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 91F1368C1E3; Thu, 22 Jun 2023 19:26:33 +0300 (EEST) Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 183D568AAB3 for ; Thu, 22 Jun 2023 19:26:27 +0300 (EEST) X-GND-Sasl: michael@niedermayer.cc Received: by mail.gandi.net (Postfix) with ESMTPSA id 4739420003 for ; Thu, 22 Jun 2023 16:26:26 +0000 (UTC) Date: Thu, 22 Jun 2023 18:26:25 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20230622162625.GD3250409@pb2> References: <20230618222805.4054410-1-michael@niedermayer.cc> <20230622134328.GA3250409@pb2> <6f1c5b3a-99cb-c2e2-41fd-da0a1273b9fe@gmail.com> <20230622150527.GC3250409@pb2> <8e1965cc-9479-5fd1-0b0b-dbbe6a26cf36@gmail.com> MIME-Version: 1.0 In-Reply-To: <8e1965cc-9479-5fd1-0b0b-dbbe6a26cf36@gmail.com> X-Spam-Flag: yes X-Spam-Level: ************ X-GND-Spam-Score: 180 X-GND-Status: SPAM Subject: Re: [FFmpeg-devel] [PATCH v2] avformat: add Software Defined Radio support X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============4661775644978831399==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============4661775644978831399== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="AkbCVLjbJ9qUtAXD" Content-Disposition: inline --AkbCVLjbJ9qUtAXD Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jun 22, 2023 at 12:10:06PM -0300, James Almer wrote: > On 6/22/2023 12:05 PM, Michael Niedermayer wrote: > > On Thu, Jun 22, 2023 at 10:55:44AM -0300, James Almer wrote: > > > On 6/22/2023 10:43 AM, Michael Niedermayer wrote: > > > > On Mon, Jun 19, 2023 at 12:28:05AM +0200, Michael Niedermayer wrote: > > > > > Signed-off-by: Michael Niedermayer > > > > > --- > > > > > configure | 4 + > > > > > doc/demuxers.texi | 71 ++ > > > > > libavformat/Makefile | 2 + > > > > > libavformat/allformats.c | 2 + > > > > > libavformat/sdrdemux.c | 1739 ++++++++++++++++++++++++++++++= ++++++++ > > > > > 5 files changed, 1818 insertions(+) > > > > > create mode 100644 libavformat/sdrdemux.c > > > >=20 > > > > Ill post a v3 later today or tomorrow that makes this work with the= RTL-SDR Blog V3 > > >=20 > > > Shouldn't the SDR "demuxer" be in libavdevice? Being AVFMT_NOFILE and= pretty > > > much a capture device, it seems to me that's the proper place. > > > I guess the problem arises with the sdrfile demuxer, which shares cod= e with > > > the other one. > >=20 > > I have no oppinon on this. I can move it to libavdevice if people prefe= r. > > do people prefer libavdevice for this ? >=20 > I do. It's a capture device and depends on an external library to interfa= ce > with hardware. And like i said, you can keep the file demuxer in lavf, wh= ere > it does fit. anyone objects if i move sdrfile then too into libavdevice ? because its the same code basically. Otherwise it would have to be some sort of #include of= c file accross libs >=20 > >=20 > >=20 > > personally i think libavdevice should be merged with libavformat. >=20 > It's been suggested plenty of times. Anton attempted to at least kickstart > it once, but his plan was shot down. > No one has tried anything ever since. How was it shut down ? 1. sent patch 2. apply it I think it should be done with the next major ABI bump thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Republics decline into democracies and democracies degenerate into despotisms. -- Aristotle --AkbCVLjbJ9qUtAXD Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZJR2KAAKCRBhHseHBAsP qwQwAJ9dTvw5P3f85q8RtlsktHqIze9nfwCfRxS+/8Qx73gJwGla8Qz0RdULUZE= =qd3a -----END PGP SIGNATURE----- --AkbCVLjbJ9qUtAXD-- --===============4661775644978831399== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============4661775644978831399==--