From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 7A418465EB for ; Thu, 22 Jun 2023 15:05:37 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C696768C196; Thu, 22 Jun 2023 18:05:35 +0300 (EEST) Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8F87168BFC0 for ; Thu, 22 Jun 2023 18:05:28 +0300 (EEST) X-GND-Sasl: michael@niedermayer.cc Received: by mail.gandi.net (Postfix) with ESMTPSA id C1FA96000C for ; Thu, 22 Jun 2023 15:05:27 +0000 (UTC) Date: Thu, 22 Jun 2023 17:05:27 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20230622150527.GC3250409@pb2> References: <20230618222805.4054410-1-michael@niedermayer.cc> <20230622134328.GA3250409@pb2> <6f1c5b3a-99cb-c2e2-41fd-da0a1273b9fe@gmail.com> MIME-Version: 1.0 In-Reply-To: <6f1c5b3a-99cb-c2e2-41fd-da0a1273b9fe@gmail.com> X-Spam-Flag: yes X-Spam-Level: ************ X-GND-Spam-Score: 180 X-GND-Status: SPAM Subject: Re: [FFmpeg-devel] [PATCH v2] avformat: add Software Defined Radio support X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============2627724110224886706==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============2627724110224886706== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ghzN8eJ9Qlbqn3iT" Content-Disposition: inline --ghzN8eJ9Qlbqn3iT Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jun 22, 2023 at 10:55:44AM -0300, James Almer wrote: > On 6/22/2023 10:43 AM, Michael Niedermayer wrote: > > On Mon, Jun 19, 2023 at 12:28:05AM +0200, Michael Niedermayer wrote: > > > Signed-off-by: Michael Niedermayer > > > --- > > > configure | 4 + > > > doc/demuxers.texi | 71 ++ > > > libavformat/Makefile | 2 + > > > libavformat/allformats.c | 2 + > > > libavformat/sdrdemux.c | 1739 +++++++++++++++++++++++++++++++++++= +++ > > > 5 files changed, 1818 insertions(+) > > > create mode 100644 libavformat/sdrdemux.c > >=20 > > Ill post a v3 later today or tomorrow that makes this work with the RTL= -SDR Blog V3 >=20 > Shouldn't the SDR "demuxer" be in libavdevice? Being AVFMT_NOFILE and pre= tty > much a capture device, it seems to me that's the proper place. > I guess the problem arises with the sdrfile demuxer, which shares code wi= th > the other one. I have no oppinon on this. I can move it to libavdevice if people prefer. do people prefer libavdevice for this ? personally i think libavdevice should be merged with libavformat. Their APIs and ABIs are the same, they are not truly seperate libs One could say libavdevice is a plugin for libavformat. And with that view having each device from libavdevice a plugin would be "better" than all together as a plugin thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB If a bugfix only changes things apparently unrelated to the bug with no further explanation, that is a good sign that the bugfix is wrong. --ghzN8eJ9Qlbqn3iT Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZJRjNgAKCRBhHseHBAsP q+SUAKCXwYVETRoQIFZ10AmxFmM8Yh9bvACgmMtM+cvpQXjBALDgqVPYeKC3mlY= =Di/5 -----END PGP SIGNATURE----- --ghzN8eJ9Qlbqn3iT-- --===============2627724110224886706== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============2627724110224886706==--