Re: [FFmpeg-devel] [PATCH v2] avformat: add Software Defined Radio support

[Michael Niedermayer <michael@niedermayer.cc>]

[-- Attachment #1.1: Type: text/plain, Size: 1624 bytes --]

On Thu, Jun 22, 2023 at 10:55:44AM -0300, James Almer wrote:
> On 6/22/2023 10:43 AM, Michael Niedermayer wrote:
> > On Mon, Jun 19, 2023 at 12:28:05AM +0200, Michael Niedermayer wrote:
> > > Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> > > ---
> > >   configure                |    4 +
> > >   doc/demuxers.texi        |   71 ++
> > >   libavformat/Makefile     |    2 +
> > >   libavformat/allformats.c |    2 +
> > >   libavformat/sdrdemux.c   | 1739 ++++++++++++++++++++++++++++++++++++++
> > >   5 files changed, 1818 insertions(+)
> > >   create mode 100644 libavformat/sdrdemux.c
> > 
> > Ill post a v3 later today or tomorrow that makes this work with the RTL-SDR Blog V3
> 
> Shouldn't the SDR "demuxer" be in libavdevice? Being AVFMT_NOFILE and pretty
> much a capture device, it seems to me that's the proper place.
> I guess the problem arises with the sdrfile demuxer, which shares code with
> the other one.

I have no oppinon on this. I can move it to libavdevice if people prefer.
do people prefer libavdevice for this ?


personally i think libavdevice should be merged with libavformat.
Their APIs and ABIs are the same, they are not truly seperate libs
One could say libavdevice is a plugin for libavformat. And with that view
having each device from libavdevice a plugin would be "better" than all
together as a plugin

thx

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If a bugfix only changes things apparently unrelated to the bug with no
further explanation, that is a good sign that the bugfix is wrong.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".