From: James Almer <jamrial@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: [FFmpeg-devel] [PATCH 3/3] avcodec/evc_frame_merge: copy input packet props to output
Date: Wed, 21 Jun 2023 13:59:49 -0300
Message-ID: <20230621165949.1112-3-jamrial@gmail.com> (raw)
In-Reply-To: <20230621165949.1112-1-jamrial@gmail.com>
Signed-off-by: James Almer <jamrial@gmail.com>
---
libavcodec/evc_frame_merge_bsf.c | 23 ++++++++++++++++++++---
1 file changed, 20 insertions(+), 3 deletions(-)
diff --git a/libavcodec/evc_frame_merge_bsf.c b/libavcodec/evc_frame_merge_bsf.c
index 36ffec5736..8a09c12dbb 100644
--- a/libavcodec/evc_frame_merge_bsf.c
+++ b/libavcodec/evc_frame_merge_bsf.c
@@ -34,7 +34,7 @@ typedef struct AccessUnitBuffer {
} AccessUnitBuffer;
typedef struct EVCFMergeContext {
- AVPacket *in;
+ AVPacket *in, *buffer_pkt;
EVCParamSets ps;
EVCParserPoc poc;
AccessUnitBuffer au_buffer;
@@ -67,6 +67,7 @@ static void evc_frame_merge_flush(AVBSFContext *bsf)
ff_evc_ps_free(&ctx->ps);
av_packet_unref(ctx->in);
+ av_packet_unref(ctx->buffer_pkt);
ctx->au_buffer.data_size = 0;
}
@@ -146,7 +147,7 @@ static int parse_nal_unit(AVBSFContext *bsf, const uint8_t *buf, int buf_size)
static int evc_frame_merge_filter(AVBSFContext *bsf, AVPacket *out)
{
EVCFMergeContext *ctx = bsf->priv_data;
- AVPacket *in = ctx->in;
+ AVPacket *in = ctx->in, *buffer_pkt = ctx->buffer_pkt;
size_t data_size;
int au_end_found = 0, err;
@@ -162,6 +163,16 @@ static int evc_frame_merge_filter(AVBSFContext *bsf, AVPacket *out)
break;
return err;
}
+ /* Buffer packets with timestamps (there should be at most one per AU)
+ * or any packet if buffer_pkt is empty. The latter is needed to
+ * passthrough positions in case there are no timestamps like with
+ * the raw EVC demuxer. */
+ if (!buffer_pkt->data ||
+ in->pts != AV_NOPTS_VALUE && buffer_pkt->pts == AV_NOPTS_VALUE) {
+ err = av_packet_ref(buffer_pkt, in);
+ if (err < 0)
+ goto end;
+ }
}
// Buffer size is not enough for buffer to store NAL unit 4-bytes prefix (length)
@@ -210,9 +221,13 @@ static int evc_frame_merge_filter(AVBSFContext *bsf, AVPacket *out)
ctx->au_buffer.data_size = 0;
err = av_new_packet(out, data_size);
+ if (err < 0)
+ goto end;
+ err = av_packet_copy_props(out, buffer_pkt);
if (err < 0)
goto end;
+ av_packet_unref(buffer_pkt);
memcpy(out->data, ctx->au_buffer.data, data_size);
err = 0;
@@ -227,7 +242,8 @@ static int evc_frame_merge_init(AVBSFContext *bsf)
EVCFMergeContext *ctx = bsf->priv_data;
ctx->in = av_packet_alloc();
- if (!ctx->in)
+ ctx->buffer_pkt = av_packet_alloc();
+ if (!ctx->in || !ctx->buffer_pkt)
return AVERROR(ENOMEM);
return 0;
@@ -238,6 +254,7 @@ static void evc_frame_merge_close(AVBSFContext *bsf)
EVCFMergeContext *ctx = bsf->priv_data;
av_packet_free(&ctx->in);
+ av_packet_free(&ctx->buffer_pkt);
ff_evc_ps_free(&ctx->ps);
ctx->au_buffer.capacity = 0;
--
2.41.0
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-06-21 17:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-21 16:59 [FFmpeg-devel] [PATCH 1/3] avcodec/evc_frame_merge: properly support packets with more than one NALU James Almer
2023-06-21 16:59 ` [FFmpeg-devel] [PATCH 2/3] avcodec/evc_frame_merge: reindent after previous commit James Almer
2023-06-21 16:59 ` James Almer [this message]
2023-06-22 17:25 ` [FFmpeg-devel] [PATCH 1/3] avcodec/evc_frame_merge: properly support packets with more than one NALU James Almer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230621165949.1112-3-jamrial@gmail.com \
--to=jamrial@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git