From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id ED99B46519 for ; Mon, 19 Jun 2023 23:36:50 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 550C268C054; Tue, 20 Jun 2023 02:36:47 +0300 (EEST) Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7849B68BF89 for ; Tue, 20 Jun 2023 02:36:41 +0300 (EEST) X-GND-Sasl: michael@niedermayer.cc Received: by mail.gandi.net (Postfix) with ESMTPSA id C85C61C0003 for ; Mon, 19 Jun 2023 23:36:40 +0000 (UTC) Date: Tue, 20 Jun 2023 01:36:40 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20230619233640.GC1391451@pb2> References: <20230619230424.30270-1-michael@niedermayer.cc> MIME-Version: 1.0 In-Reply-To: X-Spam-Flag: yes X-Spam-Level: ************ X-GND-Spam-Score: 180 X-GND-Status: SPAM Subject: Re: [FFmpeg-devel] [PATCH 1/3] avcodec/huffyuvdec: avoid undefined behavior with get_vlc2() failure X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============7377020509246568593==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============7377020509246568593== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="9HYC6QbAtwudymEc" Content-Disposition: inline --9HYC6QbAtwudymEc Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jun 20, 2023 at 01:05:45AM +0200, Paul B Mahol wrote: > Shouldnt it error out instead? yes but that would make it slower. Also i think real files (not fuzzeed fil= es) would use vlc tables that have no "holes" that can generate invalid returns so the check might on top of being slow also be not that useful. But i surely can add a check if thats what people prefer? thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Republics decline into democracies and democracies degenerate into despotisms. -- Aristotle --9HYC6QbAtwudymEc Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZJDmgAAKCRBhHseHBAsP q57hAJ49TI3t5TgqyLXwP3jzprHdkmO/UwCeOythGRYO6xzsHuYHG735tDhPWuc= =vrZd -----END PGP SIGNATURE----- --9HYC6QbAtwudymEc-- --===============7377020509246568593== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============7377020509246568593==--