From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id E055B46495 for ; Sun, 18 Jun 2023 11:20:21 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1F9B568BF6E; Sun, 18 Jun 2023 14:20:14 +0300 (EEST) Received: from haasn.dev (haasn.dev [78.46.187.166]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A697F68BF50 for ; Sun, 18 Jun 2023 14:20:08 +0300 (EEST) Received: from haasn.dev (unknown [10.30.0.2]) by haasn.dev (Postfix) with ESMTP id 6B89C42350; Sun, 18 Jun 2023 13:20:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=haasn.xyz; s=mail; t=1687087208; bh=WAm6lPWXPVKyVWWiTpC2BSGDJdXtOQ03zruHClRamIg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=j4mM6bc5UWGnxqB7LIT1uhAlWl6tuxCOytL0mmH0j1k3nlH/b4dGCjXGYgD0TlXKO PBzvD8qAqwfFcs3ZW2u0atMKKEH5fgRSbGZO6opMNaBRPvy96reEZYXoTiD6rpsvWb GvFGaxLq85BQLyHr950SkrOHa9Yv9d6Ymkidy1ro= From: Niklas Haas To: ffmpeg-devel@ffmpeg.org Date: Sun, 18 Jun 2023 13:16:53 +0200 Message-ID: <20230618111955.40994-3-ffmpeg@haasn.xyz> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230618111955.40994-2-ffmpeg@haasn.xyz> References: <20230618111955.40994-2-ffmpeg@haasn.xyz> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH v2 01/22] lavfi/vf_libplacebo: drop redundant case X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Niklas Haas Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: From: Niklas Haas If the input queue is EOF, then the s->status check should already have covered it, and prevented the code from getting this far. If we still hit this case for some reason, it's probably a bug. Better to hit the AVERROR_BUG branch. --- libavfilter/vf_libplacebo.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/libavfilter/vf_libplacebo.c b/libavfilter/vf_libplacebo.c index 242c8a13f5a..a048424cecc 100644 --- a/libavfilter/vf_libplacebo.c +++ b/libavfilter/vf_libplacebo.c @@ -949,9 +949,6 @@ static int libplacebo_activate(AVFilterContext *ctx) if (!s->fps.num) av_fifo_drain2(s->out_pts, 1); return output_frame_mix(ctx, &mix, pts); - case PL_QUEUE_EOF: - ff_outlink_set_status(outlink, AVERROR_EOF, pts); - return 0; case PL_QUEUE_ERR: return AVERROR_EXTERNAL; } -- 2.41.0 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".