From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id A9B5B46495 for ; Sun, 18 Jun 2023 10:18:33 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E746468BF46; Sun, 18 Jun 2023 13:18:29 +0300 (EEST) Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id DC2BB68B79A for ; Sun, 18 Jun 2023 13:18:22 +0300 (EEST) Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-3f8d258f203so17486875e9.1 for ; Sun, 18 Jun 2023 03:18:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687083501; x=1689675501; h=user-agent:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:mail-followup-to :message-id:subject:to:from:date:from:to:cc:subject:date:message-id :reply-to; bh=auwkOMzjtKL4s/ulKu33kKU7I+YfTDNnECSTZpXYz3Q=; b=oDRKz35l5kyBi44BZOf8umzwh9dr/27xGWn0RtqmYFpfY1bYEIJ58f+OamQ7fE6Z4o 85pm5EExv/JTAaqzDXHR3eWokHnqGYC2V0VXrc46aPAh+V6iCGTQObg/vXuk0w9/jquk PiHgUtNMGk++U08VeuHZuSk/4wzdRD2HaZQsyJJ1ooJboXXwhVbefYsL2/9Qu92Vwp9V eX/5xHMbvx2uDEfkuMPAfdmareO+fF/H7r9ZOcG6ndU1Knxx3i6+7+5pfC8LvgBwJ+kp mdaGW1rJhJcpR7QdEtdAHErYSTj71kbOvGUghYPcyeC/zlAzR3F91h8Vt92pG3iEV551 6hbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687083501; x=1689675501; h=user-agent:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:mail-followup-to :message-id:subject:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=auwkOMzjtKL4s/ulKu33kKU7I+YfTDNnECSTZpXYz3Q=; b=T20Gru9cBwWIXFk0In/CquvLcIWeeMC0OJkyQ79GK3gUQsBZSKIDiPUiadbggqRGIr m/4M/6j9mv0JgF6n5JN5n4bxBhOqDP+QLJtJbzB4+oEKlweBvnDcv1/PqRV+eyUQgs4j e8n8VG9MGsA4GdRe8VGPJtCXk/l7wgGbp82ZNhw1dXhn5CJHGpJwG68eXfFOH5w3KLd0 CO2PeVg9dc1411HSczTs1BNdiMnJ3MVT1FFp8dBEXiOVJhWsAfppKNxIEjZM5jpXv3iv fZwTzmD80UpLm7a0AGcOi4CVogchaB/DTw+PUTXFefvWyfKMeDuRK07qcoFUPBeoF1oV pHDQ== X-Gm-Message-State: AC+VfDxS6kEndG0A36t+3/MZxSp1onU7IIY+BqkJsFrikRSlmaErXsud 1FIkf//qnDEBKBHt5zkad+L34qTiMIU= X-Google-Smtp-Source: ACHHUZ6jp2A3GRO7KZ9tfakOB+2wQYciTR7F2aN5W8Aad3+e7U5ZJ/g6KlGGA+YX4p6AkzmGBe4mOQ== X-Received: by 2002:a1c:7703:0:b0:3f6:f56:9ad with SMTP id t3-20020a1c7703000000b003f60f5609admr5069599wmi.13.1687083501260; Sun, 18 Jun 2023 03:18:21 -0700 (PDT) Received: from mariano ([151.56.109.141]) by smtp.gmail.com with ESMTPSA id r19-20020a05600c285300b003f605566610sm7300083wmb.13.2023.06.18.03.18.20 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Jun 2023 03:18:20 -0700 (PDT) Received: by mariano (Postfix, from userid 1000) id 2C99ABFB73; Sun, 18 Jun 2023 12:18:19 +0200 (CEST) Date: Sun, 18 Jun 2023 12:18:19 +0200 From: Stefano Sabatini To: FFmpeg development discussions and patches Message-ID: <20230618101819.GC6623@mariano> Mail-Followup-To: FFmpeg development discussions and patches References: <8eb9290f3c9cdae75b38c45a5d49ee624951a849.camel@amazon.it> <20230521231741.GB14958@mariano> <20230604152912.GC4274@mariano> <20230611171510.GA53039@mariano> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.13.2 (2019-12-18) Subject: Re: [FFmpeg-devel] [PATCH] Optimization: support for libx264's mb_info X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On date Monday 2023-06-12 17:28:10 +0000, Carotti, Elias wrote: > Hi Stefano, > Here is the revised patch according to your suggestions. This should > allow for efficient inlining of the methods computing the map of > skipped macrobloks. > Best,=A0 > Elias [...] = > = > From 0e7979250231edbe0b845cee96c473bc6e07d46b Mon Sep 17 00:00:00 2001 > From: Elias Carotti > Date: Wed, 19 Apr 2023 11:49:39 +0200 > Subject: [PATCH] Add support for libx264's MB_INFO > = > libx264's x264_image_properties_t, which is passed to the encoding functi= on, > contains a field to pass down information on the portions of the frame wh= ich > changed with respect to the previous one (used for prediction) to mark > unchanged macroblocks P_SKIP. > --- > libavcodec/libx264.c | 91 ++++++++++++++++++++++++++++++++++++++++++ > libavutil/Makefile | 4 ++ > libavutil/frame.h | 10 +++++ > libavutil/video_hint.c | 89 +++++++++++++++++++++++++++++++++++++++++ > libavutil/video_hint.h | 87 ++++++++++++++++++++++++++++++++++++++++ > 5 files changed, 281 insertions(+) > create mode 100644 libavutil/video_hint.c > create mode 100644 libavutil/video_hint.h Note: maybe this should be split in two parts, one about libavutil and one about libx264. The libavutil part should also contain a minor bump for the new feature, same for libavcodec (with corresponding changes in doc/APIchanges). I don't know if we track internal dependencies (to define the minor libavutil version needed for the new libx264 feature in libavcodec). What's the current practice here? Looks good to me otherwise (still it would be good if someone else can have a look at it). _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".