From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id B00304679A for ; Sun, 18 Jun 2023 10:05:02 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id CD64768BF2A; Sun, 18 Jun 2023 13:04:58 +0300 (EEST) Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7928968B9AB for ; Sun, 18 Jun 2023 13:04:52 +0300 (EEST) Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-3f900cd3f96so11147625e9.2 for ; Sun, 18 Jun 2023 03:04:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687082690; x=1689674690; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:to:from:date:from:to:cc:subject :date:message-id:reply-to; bh=C5PmFyngR2A9kM0c2T3mHcuteZcpsBBeSXIpcYr0/5Y=; b=HoGfxuy37NKWjb8LetLjckhscstnHhdI8ms1uKsanpXkklzZg7r1e7qK32glRSMil+ 94bCZM+My7mtZjt2MsGtgQJupKBe+F5zDbAVuLDJQRpRB2HcYarbY1ibULdkKjEzvaHf jxu1nM9fPdguDwCrcdGmWnAjIogf858kHlzrEkj/V0QR5/AUqlkuKdOH4tghLdvczMt4 Qz7cNnvS+rBV32YQLKpPdT0PtlLYYdPW6SYtbOZ0fcUHUwYc5C+miwmaLk/JZffKppk2 maCp86uC4DaiXBcIoCsHmA1PYZz6sB7ucFGhiTG0NS1YMuEN2ozpCDIHA2CYGQ684UCI +TnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687082690; x=1689674690; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=C5PmFyngR2A9kM0c2T3mHcuteZcpsBBeSXIpcYr0/5Y=; b=KTBYtdUJ83bfVQSlu5CBXFER1k2XHY7Y1yFMgYOpSistzzlZ8VnCiSdLe3Mf/0zhTq tNrZypax7Q0WQanK6Nbh4GmgP5MhRjCgXH19RglJ0CKu7mvaDNpUf2GrK0LfYesh0KE9 CyGMC4BhHICBb3WVnrla8GICcfuKO/N57ny8ilgoPUnR5o/tKyqTJ1wXU7Z4d2+sk3Oq b6xOBVXGIvL8tqL63pehi8hL0+Zg5pCfj3MjQdEJgfqMmovnMusgbsJKNwDg9kXlKrsp s+EP3Uu4dy6XQa3VMC3Edx2SLRm+OtiWbBQlTX5lOIULrRkCIaAKfM7a4AnfUxkRfELT xlYQ== X-Gm-Message-State: AC+VfDzT+j/9W4ee+fj31ldjB+62H/8BYVxVXqde1dY6sbNrZosMJ212 YfxGHmRBeXyl9q9cQo9p82eBG9azVfs= X-Google-Smtp-Source: ACHHUZ6/ZUPE2SPUHui9pP5nTWhVrL6mnJEuM6MRvw1AF4Lp/iyhk3c/SMv5zYmso+kQPM68VwKiyA== X-Received: by 2002:a1c:7209:0:b0:3f9:a10:10d0 with SMTP id n9-20020a1c7209000000b003f90a1010d0mr1394662wmc.17.1687082690336; Sun, 18 Jun 2023 03:04:50 -0700 (PDT) Received: from mariano ([151.56.109.141]) by smtp.gmail.com with ESMTPSA id c25-20020a05600c0ad900b003f18b942338sm7368962wmr.3.2023.06.18.03.04.49 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Jun 2023 03:04:49 -0700 (PDT) Received: by mariano (Postfix, from userid 1000) id E6397BFB73; Sun, 18 Jun 2023 12:04:48 +0200 (CEST) Date: Sun, 18 Jun 2023 12:04:48 +0200 From: Stefano Sabatini To: FFmpeg development discussions and patches Message-ID: <20230618100448.GB6623@mariano> Mail-Followup-To: FFmpeg development discussions and patches References: <8eb9290f3c9cdae75b38c45a5d49ee624951a849.camel@amazon.it> <20230521231741.GB14958@mariano> <20230604152912.GC4274@mariano> <20230611171510.GA53039@mariano> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.13.2 (2019-12-18) Subject: Re: [FFmpeg-devel] [PATCH] Optimization: support for libx264's mb_info X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On date Monday 2023-06-12 17:38:43 +0000, Carotti, Elias wrote: > On Mon, 2023-06-12 at 18:23 +1000, Kieran Kunhya wrote: > > CAUTION: This email originated from outside of the organization. Do > > not click links or open attachments unless you can confirm the sender > > and know the content is safe. > > > > > > > > Looks good to me otherwise, maybe Michael/Anton or someone else > > > want > > > to have a look? > > > > > > > I don't think we should be adding what is essentially libx264 > > specific code > > to the public libavutil API. > > > > Kieran > > Hi Kieran, > I disagree: this is not more libx264-specific than most other code in > libavutil/libx264.c, like, say, the region of interest code. > > P_SKIPs are in the standard and this API is designed to provide a > generic way to generate them when the changing portion of a frame is > known in advance. > > Should other encoders (and I mean it in the broadest sense, not > specifically h.264 ones) support a method for feeding in hints about > unchanged portions of a frame, it shouldn't be hard to write the > encoder-specific code for them in the respective encoder-specific file. > > In fact, the public api provided only allows to specify as side data a > list of rectangles (in pixels' space) on the frame (just like it's done > for the region of interest) which is then translated into the specific > libx264 hinting mechanism (in macroblock space.) +1, I don't think there is anything specific for x264 here. In fact, we could even add a filter to compute the hinting data and export it in the side data. If you think this is a good idea, we could split the patches in two parts to make this more apparent. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".