From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id C3D72411D3 for ; Mon, 12 Jun 2023 03:33:40 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 955BD68C333; Mon, 12 Jun 2023 06:33:35 +0300 (EEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id AA13768BE21 for ; Mon, 12 Jun 2023 06:33:28 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1686540814; x=1718076814; h=from:to:subject:date:message-id:mime-version: content-transfer-encoding; bh=2nB+dsi7Gvx/GuVqumIFh8NA07DLPF98UvhdhpJPVCI=; b=OUXSIq59f13R+rQT+j2GdohVbUVZsyvWx+4eNF2lr0Xbw83cSjkWpHnJ N6BCtkCjjiIGgclnPfKFxbi5m59vTxi0dJoVlhlKGBLwVteZevtaRJIQY eDMoSuNxjYnNOfamALnJafqvX1ODb2pzdAvaiHhVnnjBK6Qc0+AqFWUvf Ux7QVCd96hJa/CaJSFkVCoxUxYzg51tRxeXUPlJHJjGGfMpdEkfERgakF Zwt15GiXJl8Mi63PhKnq14IvSYzpX8Do+l/8AWEIs4GG/rOaHycYCaVRN FF+mfpImh2z+Fh4G3j67IEGc/nVGk7WZS0wpz18qWpX0GhTLz31SNYCIx w==; X-IronPort-AV: E=McAfee;i="6600,9927,10738"; a="355431723" X-IronPort-AV: E=Sophos;i="6.00,235,1681196400"; d="scan'208";a="355431723" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jun 2023 20:33:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10738"; a="800867053" X-IronPort-AV: E=Sophos;i="6.00,235,1681196400"; d="scan'208";a="800867053" Received: from t-dg2.sh.intel.com ([10.238.200.108]) by FMSMGA003.fm.intel.com with ESMTP; 11 Jun 2023 20:33:25 -0700 From: Fei Wang To: ffmpeg-devel@ffmpeg.org Date: Mon, 12 Jun 2023 11:33:11 +0800 Message-Id: <20230612033311.363757-1-fei.w.wang@intel.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH v1] fftools/ffmpeg_dec: Don't keep sending frame to filters in flushing X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Filter may has a limited frame pool size. Do not always send frame to filters without reaping. Fix the regression of commit 5fa00b38e6. Example cmd: $ ffmpeg -threads 20 -init_hw_device vaapi=hw:/dev/dri/renderD128 \ -hwaccel_output_format vaapi -hwaccel vaapi -i avc_1080P.mp4 \ -vf 'scale_vaapi=w=720:h=480' -f null - Signed-off-by: Fei Wang --- fftools/ffmpeg_dec.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/fftools/ffmpeg_dec.c b/fftools/ffmpeg_dec.c index 799be63215..d6b34402f8 100644 --- a/fftools/ffmpeg_dec.c +++ b/fftools/ffmpeg_dec.c @@ -531,6 +531,12 @@ int dec_packet(InputStream *ist, const AVPacket *pkt, int no_eof) av_frame_unref(frame); if (ret < 0) exit_program(1); + + // During flushing, break out to reap filter once send a frame to filters to + // avoid drain out filter's output frame pool. Especially for HW filters which + // always have a limited frame pool size. + if (!pkt) + return 0; } } -- 2.25.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".