From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 5BC754621E for ; Fri, 9 Jun 2023 18:36:30 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4A10A68C331; Fri, 9 Jun 2023 21:36:28 +0300 (EEST) Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [217.70.183.194]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9493368C2C9 for ; Fri, 9 Jun 2023 21:36:21 +0300 (EEST) X-GND-Sasl: michael@niedermayer.cc Received: by mail.gandi.net (Postfix) with ESMTPSA id 5E54D40005 for ; Fri, 9 Jun 2023 18:36:19 +0000 (UTC) Date: Fri, 9 Jun 2023 20:36:17 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20230609183617.GJ1391451@pb2> References: <20230608142637.45033-1-leo.izen@gmail.com> <20230608142637.45033-5-leo.izen@gmail.com> <168627796328.3843.8714735093481005983@lain.khirnov.net> <08c957d8-5cae-384f-a345-a0174d06677e@gmail.com> MIME-Version: 1.0 In-Reply-To: <08c957d8-5cae-384f-a345-a0174d06677e@gmail.com> X-Spam-Flag: yes X-Spam-Level: ************ X-GND-Spam-Score: 180 X-GND-Status: SPAM Subject: Re: [FFmpeg-devel] [PATCH 4/5] avformat/jpegxl_probe: inline various ret < 0 checks X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============3456167956794008203==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============3456167956794008203== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="sEhN1cmIR+YbgQE4" Content-Disposition: inline --sEhN1cmIR+YbgQE4 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jun 08, 2023 at 11:44:38PM -0300, James Almer wrote: > On 6/8/2023 11:32 PM, Anton Khirnov wrote: > > Quoting Leo Izen (2023-06-08 16:26:36) > > > Inlines some ret < 0 checks to look like: > > > if ((ret =3D func()) < 0) > > > return ret; > > >=20 > > > which clarifies code slightly. > >=20 > > FWIW I find this variant less readable. > > But it's your code, so up to you. >=20 > Agree. It's both less readable > and more prone to mistakes. yes, we had bugs with people misplacing a () in exactly this style of checking the return [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB While the State exists there can be no freedom; when there is freedom there will be no State. -- Vladimir Lenin --sEhN1cmIR+YbgQE4 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZINxHQAKCRBhHseHBAsP qynFAJ9grXC7zI1W0UNHHzas67Q65CpfmgCgittrRe3+ktSKzoDc02tA055u0kI= =pnDP -----END PGP SIGNATURE----- --sEhN1cmIR+YbgQE4-- --===============3456167956794008203== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============3456167956794008203==--