From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id CFC1546702 for ; Wed, 7 Jun 2023 22:03:04 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4B03768BE61; Thu, 8 Jun 2023 01:03:01 +0300 (EEST) Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 17B9D68BAEB for ; Thu, 8 Jun 2023 01:02:55 +0300 (EEST) X-GND-Sasl: michael@niedermayer.cc Received: by mail.gandi.net (Postfix) with ESMTPSA id 431A91C0003 for ; Wed, 7 Jun 2023 22:02:54 +0000 (UTC) Date: Thu, 8 Jun 2023 00:02:53 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20230607220253.GH1391451@pb2> References: <20230526205505.23569-1-leo.izen@gmail.com> <20230526205505.23569-3-leo.izen@gmail.com> MIME-Version: 1.0 In-Reply-To: <20230526205505.23569-3-leo.izen@gmail.com> X-Spam-Flag: yes X-Spam-Level: *********** X-GND-Spam-Score: 165 X-GND-Status: SPAM Subject: Re: [FFmpeg-devel] [PATCH v4 2/2] avformat/jpegxl_anim_dec: add animated JPEG XL demuxer X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============7608837259027441799==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============7608837259027441799== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="YkNwngLRNOQA9swf" Content-Disposition: inline --YkNwngLRNOQA9swf Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, May 26, 2023 at 04:55:05PM -0400, Leo Izen wrote: > Animated JPEG XL files requires a separate demuxer than image2, because > the timebase information is set by the demuxer. Should the timebase of > an animated JPEG XL file be incompatible with the timebase set by the > image2pipe demuxer (usually 1/25 unless set otherwise), rescaling will > fail. Adding a separate demuxer for animated JPEG XL files allows the > timebase to be set correctly. >=20 > Signed-off-by: Leo Izen > --- > MAINTAINERS | 1 + > libavformat/Makefile | 1 + > libavformat/allformats.c | 1 + > libavformat/img2dec.c | 2 +- > libavformat/jpegxl_anim_dec.c | 266 ++++++++++++++++++++++++++++++++++ > libavformat/jpegxl_probe.c | 19 +-- > libavformat/jpegxl_probe.h | 7 +- > libavformat/version.h | 2 +- > 8 files changed, 287 insertions(+), 12 deletions(-) > create mode 100644 libavformat/jpegxl_anim_dec.c [...] > diff --git a/libavformat/jpegxl_probe.h b/libavformat/jpegxl_probe.h > index 2960e81e11..496445fbce 100644 > --- a/libavformat/jpegxl_probe.h > +++ b/libavformat/jpegxl_probe.h > @@ -27,6 +27,11 @@ > #define FF_JPEGXL_CODESTREAM_SIGNATURE_LE 0x0aff > #define FF_JPEGXL_CONTAINER_SIGNATURE_LE 0x204c584a0c000000 > =20 > -int ff_jpegxl_verify_codestream_header(const uint8_t *buf, int buflen); > +/** > + * @brief verify that a codestream header is valid > + * @return Negative upon error, 0 upon verifying that the codestream is = not animated, > + * and 1 upon verifying that it is animated > + */ > +int ff_jpegxl_verify_codestream_header(const uint8_t *buf, int buflen, i= nt validate_level); An argument is added and documentation is written but These 2 changes seem unrelated, the added documentation seems not related t= o the added argument Also the added argument should be documented. thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Those who would give up essential Liberty, to purchase a little temporary Safety, deserve neither Liberty nor Safety -- Benjamin Franklin --YkNwngLRNOQA9swf Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZID+hQAKCRBhHseHBAsP q3w/AJ43jbY+m+ZuJugcGQIf8NGcUSTZeACgkbU12AErO1tOF/RV0E6ZvSSAUQs= =om7W -----END PGP SIGNATURE----- --YkNwngLRNOQA9swf-- --===============7608837259027441799== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============7608837259027441799==--