Re: [FFmpeg-devel] [PATCH v4 2/2] avformat/jpegxl_anim_dec: add animated JPEG XL demuxer

From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v4 2/2] avformat/jpegxl_anim_dec: add animated JPEG XL demuxer
Date: Thu, 8 Jun 2023 00:02:53 +0200
Message-ID: <20230607220253.GH1391451@pb2> (raw)
In-Reply-To: <20230526205505.23569-3-leo.izen@gmail.com>

[-- Attachment #1.1: Type: text/plain, Size: 2170 bytes --]

On Fri, May 26, 2023 at 04:55:05PM -0400, Leo Izen wrote:
> Animated JPEG XL files requires a separate demuxer than image2, because
> the timebase information is set by the demuxer. Should the timebase of
> an animated JPEG XL file be incompatible with the timebase set by the
> image2pipe demuxer (usually 1/25 unless set otherwise), rescaling will
> fail. Adding a separate demuxer for animated JPEG XL files allows the
> timebase to be set correctly.
> 
> Signed-off-by: Leo Izen <leo.izen@gmail.com>
> ---
>  MAINTAINERS                   |   1 +
>  libavformat/Makefile          |   1 +
>  libavformat/allformats.c      |   1 +
>  libavformat/img2dec.c         |   2 +-
>  libavformat/jpegxl_anim_dec.c | 266 ++++++++++++++++++++++++++++++++++
>  libavformat/jpegxl_probe.c    |  19 +--
>  libavformat/jpegxl_probe.h    |   7 +-
>  libavformat/version.h         |   2 +-
>  8 files changed, 287 insertions(+), 12 deletions(-)
>  create mode 100644 libavformat/jpegxl_anim_dec.c

[...]

> diff --git a/libavformat/jpegxl_probe.h b/libavformat/jpegxl_probe.h
> index 2960e81e11..496445fbce 100644
> --- a/libavformat/jpegxl_probe.h
> +++ b/libavformat/jpegxl_probe.h
> @@ -27,6 +27,11 @@
>  #define FF_JPEGXL_CODESTREAM_SIGNATURE_LE 0x0aff
>  #define FF_JPEGXL_CONTAINER_SIGNATURE_LE 0x204c584a0c000000
>  
> -int ff_jpegxl_verify_codestream_header(const uint8_t *buf, int buflen);
> +/**
> + * @brief verify that a codestream header is valid
> + * @return Negative upon error, 0 upon verifying that the codestream is not animated,
> + *         and 1 upon verifying that it is animated
> + */
> +int ff_jpegxl_verify_codestream_header(const uint8_t *buf, int buflen, int validate_level);

An argument is added and documentation is written but
These 2 changes seem unrelated, the added documentation seems not related to the added
argument

Also the added argument should be documented.

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Those who would give up essential Liberty, to purchase a little
temporary Safety, deserve neither Liberty nor Safety -- Benjamin Franklin

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".