From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 11B8C42337 for ; Wed, 7 Jun 2023 19:17:18 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 824EC68BFA9; Wed, 7 Jun 2023 22:17:15 +0300 (EEST) Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [217.70.183.194]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2EC0A68BE50 for ; Wed, 7 Jun 2023 22:17:08 +0300 (EEST) X-GND-Sasl: michael@niedermayer.cc Received: by mail.gandi.net (Postfix) with ESMTPSA id 5DE1840004 for ; Wed, 7 Jun 2023 19:17:07 +0000 (UTC) Date: Wed, 7 Jun 2023 21:17:06 +0200 From: Michael Niedermayer To: ffmpeg-devel@ffmpeg.org Message-ID: <20230607191706.GE870501@pb2> References: <20230531142612.443E941082C@natalya.videolan.org> MIME-Version: 1.0 In-Reply-To: <20230531142612.443E941082C@natalya.videolan.org> X-Spam-Flag: yes X-Spam-Level: ******************** X-GND-Spam-Score: 310 X-GND-Status: SPAM Subject: Re: [FFmpeg-devel] [FFmpeg-cvslog] fftools/ffmpeg: rework setting sub2video parameters X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============3903948326867757514==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============3903948326867757514== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="wULyF7TL5taEdwHz" Content-Disposition: inline --wULyF7TL5taEdwHz Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, May 31, 2023 at 02:26:11PM +0000, Anton Khirnov wrote: > ffmpeg | branch: master | Anton Khirnov | Tue May 23 = 22:54:23 2023 +0200| [20cacfe4936a8d5b643421b5ca93bb098f6b76dd] | committer= : Anton Khirnov >=20 > fftools/ffmpeg: rework setting sub2video parameters >=20 > Set them in ifilter_parameters_from_dec(), similarly to audio/video > streams. This reduces the extent to which sub2video filters need to be > treated specially. >=20 > > http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=3Dcommit;h=3D20cacfe49= 36a8d5b643421b5ca93bb098f6b76dd > --- >=20 > fftools/ffmpeg.c | 6 ++--- > fftools/ffmpeg_demux.c | 21 ++++++++++++++++++ > fftools/ffmpeg_filter.c | 58 +++++++++++++++----------------------------= ------ > 3 files changed, 41 insertions(+), 44 deletions(-) This breaks subtitle location and size =2E/ffmpeg -i ~/tickets/4752/dump_dvbsubtitles.mp4 -y -ss 5 -t 1 -filter_c= omplex '[0:v][0:s]overlay' /tmp/file4752.ts && ffplay /tmp/file4752.ts https://samples.ffmpeg.org/ffmpeg-bugs/trac/ticket4752/dump_dvbsubtitles.mp4 Before this commit the subtitles are centered at the bottom of the screen after this patch the subtitles are tiny in the left middle of the screen In the following case the subtitles disappear completely: =2E/ffmpeg -i ~/tickets/679/subtitles.ts -filter_complex '[0:v][0:s:0]overl= ay[vid]' -map '[vid]' -bitexact -t 3 file-4744-3.avi https://samples.ffmpeg.org/ffmpeg-bugs/trac/ticket4744/subtitles.ts [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Dictatorship naturally arises out of democracy, and the most aggravated form of tyranny and slavery out of the most extreme liberty. -- Plato --wULyF7TL5taEdwHz Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZIDXrgAKCRBhHseHBAsP qzxWAJ9Erig4tgMgBof+drCNva99Qc9cmACghjFsYwx+DKT/BFa8oQHmOAo1lNc= =0PDo -----END PGP SIGNATURE----- --wULyF7TL5taEdwHz-- --===============3903948326867757514== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============3903948326867757514==--