From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id AD6A546103 for ; Mon, 5 Jun 2023 22:10:08 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9828668C3FC; Tue, 6 Jun 2023 01:10:05 +0300 (EEST) Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 52BEE68C24E for ; Tue, 6 Jun 2023 01:09:58 +0300 (EEST) X-GND-Sasl: michael@niedermayer.cc Received: by mail.gandi.net (Postfix) with ESMTPSA id 7AEC020004 for ; Mon, 5 Jun 2023 22:09:57 +0000 (UTC) Date: Tue, 6 Jun 2023 00:09:56 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20230605220956.GE1391451@pb2> References: <20230604195322.26982-1-michael@niedermayer.cc> <168596047355.3843.6740828857692828996@lain.khirnov.net> MIME-Version: 1.0 In-Reply-To: <168596047355.3843.6740828857692828996@lain.khirnov.net> Subject: Re: [FFmpeg-devel] [PATCH v2] avcodec/noise_bsf: Check for wrapped frames X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============2481066474632591550==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============2481066474632591550== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ZXnrAYM8PVd0GhSK" Content-Disposition: inline --ZXnrAYM8PVd0GhSK Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jun 05, 2023 at 12:21:13PM +0200, Anton Khirnov wrote: > Quoting Michael Niedermayer (2023-06-04 21:53:22) > > Wrapped frames contain pointers so they need specific code to > > noise them, the generic code would lead to segfaults > >=20 > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/noise_bsf.c | 7 +++++++ > > 1 file changed, 7 insertions(+) > >=20 > > diff --git a/libavcodec/noise_bsf.c b/libavcodec/noise_bsf.c > > index 168f3aa373..2985a8ec4f 100644 > > --- a/libavcodec/noise_bsf.c > > +++ b/libavcodec/noise_bsf.c > > @@ -86,6 +86,13 @@ static int noise_init(AVBSFContext *ctx) > > return AVERROR(ENOMEM); > > } > > =20 > > + if (ctx->par_in->codec_id =3D=3D AV_CODEC_ID_WRAPPED_AVFRAME && > > + strcmp(s->amount_str, "0") > > + ) { >=20 > Why is this on a separate line? Probably because i pressed the enter key. Ill remove the \n thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB It is dangerous to be right in matters on which the established authorities are wrong. -- Voltaire --ZXnrAYM8PVd0GhSK Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZH5dNAAKCRBhHseHBAsP qyhkAJ9QT4fzhWBitH1EqrCHHUWqJp8ndgCgkkjnA299NQ/IDAkDAXiqJZXLkt8= =xQre -----END PGP SIGNATURE----- --ZXnrAYM8PVd0GhSK-- --===============2481066474632591550== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============2481066474632591550==--