From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] avcodec/noise_bsf: Check for wrapped frames
Date: Sun, 4 Jun 2023 21:54:11 +0200
Message-ID: <20230604195411.GC1391451@pb2> (raw)
In-Reply-To: <b7196da4-90e7-d0df-b640-a05149a34018@gyani.pro>
[-- Attachment #1.1: Type: text/plain, Size: 920 bytes --]
On Mon, Jun 05, 2023 at 12:06:15AM +0530, Gyan Doshi wrote:
>
>
> On 2023-06-04 11:43 pm, Michael Niedermayer wrote:
> > On Sun, Jun 04, 2023 at 08:07:25PM +0200, Michael Niedermayer wrote:
> > > Wrapped frames contain pointers so they need specific code to
> > > noise them, the generic code would lead to segfaults
> > >
> > > Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> > > ---
> > > libavcodec/noise_bsf.c | 5 +++++
> > > 1 file changed, 5 insertions(+)
> > I intend to apply this soon as noising pointers is not too good
>
> Their contents can't be manipulated but they can still be dropped
> conditionally, so the bsf can still handle them if amount_str is NULL.
ok, ive sent a new patch
thx
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Opposition brings concord. Out of discord comes the fairest harmony.
-- Heraclitus
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2023-06-04 19:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-04 18:07 Michael Niedermayer
2023-06-04 18:13 ` Michael Niedermayer
2023-06-04 18:36 ` Gyan Doshi
2023-06-04 19:54 ` Michael Niedermayer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230604195411.GC1391451@pb2 \
--to=michael@niedermayer.cc \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git