From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 755F340C42 for ; Sun, 4 Jun 2023 14:25:55 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E0EB668C3C3; Sun, 4 Jun 2023 17:25:51 +0300 (EEST) Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com [209.85.218.44]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A374668C2B9 for ; Sun, 4 Jun 2023 17:25:45 +0300 (EEST) Received: by mail-ej1-f44.google.com with SMTP id a640c23a62f3a-9768fd99c0cso354869966b.0 for ; Sun, 04 Jun 2023 07:25:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685888744; x=1688480744; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:to:from:date:from:to:cc:subject :date:message-id:reply-to; bh=KsLOPfZNFIfChT8+WUWjrtfDn0DkXX/RQgd2ElqULpU=; b=XDQEe6BrSonUf2wztJVbGA5Bd1tJK8Xz3ckNsKnP60ip22gxpVMDTWV6gvnOeTPGgr QpAk76XP7wBQw1LLk/BD+aAUwLqVN50kqRRWG+nR04J9jNGAXLumBoa4RZC5N1rJ1iMi STxFhJQQFQbmtCNGKBZNRWf3MX0CvDpBv2km39ygkWvZ8z8X1BLlvoDpYxgIyWr5ky6O ZKoPolxFmuv/607Tn+iPvKkOg/qnpROGVu9x523qQ8E01Pt069HzcjfWF/uvBlN+NJ7Z 6uSKcLpOBrA5vf/GQqtXtmULegBy8QJxVeJgFvGmzl67SJDFHKuRqaooSw0M0NkEhCoO jQ+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685888744; x=1688480744; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=KsLOPfZNFIfChT8+WUWjrtfDn0DkXX/RQgd2ElqULpU=; b=g1LXSpENYaTYGrwSd9NWTVL+ZsuiWcAtJhOLgaFv7yJgS7ygepjRRjZlYaTOqgHdU/ Heqt2sLlXok92Mjnx3EU2VI81jJ5pZgNSln/n788+nHMHdQT0ev5ZuEyVU67gfYzMoiQ CQRKALwerBR3bdqaPWo9ieydgt9k/cdQeN9eSEIx/eYX1o+zgQSGK8ko08u5pjN9Q9bo w8G5cwsFZK56+r3fimqE/5cXcXRPQfZ9xXipvKVnfRPtIcEgoYft0BZaTyDYsj1WS4Vq 9/38ndG/Ae3j2KCJY3BeVP4r1xnVlrN6zr/gapgVDMTkz8BPAvcuK7Uwgxtrl5wMJ0fL cNcw== X-Gm-Message-State: AC+VfDy/1LvopVKotPHxQ0GPyNFoTU441OXv3z+alArD6Wj0PcfiYQgT /I6AEIzeTK+77Fj27m6myysPc3pJecxQOA== X-Google-Smtp-Source: ACHHUZ7WozpbfSQWH1wCuwXhd95GhP/cq8r7/I5bcVJSQbf4PNrU2ArOfSb2YZm3535qdPPJ+nBd9g== X-Received: by 2002:a17:907:d88:b0:973:e888:2225 with SMTP id go8-20020a1709070d8800b00973e8882225mr3738861ejc.35.1685888744153; Sun, 04 Jun 2023 07:25:44 -0700 (PDT) Received: from mariano (host-95-248-150-22.retail.telecomitalia.it. [95.248.150.22]) by smtp.gmail.com with ESMTPSA id b21-20020a170906709500b00965a0f30fbfsm3140096ejk.186.2023.06.04.07.25.42 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 04 Jun 2023 07:25:43 -0700 (PDT) Received: by mariano (Postfix, from userid 1000) id 99EB0BFB73; Sun, 4 Jun 2023 16:25:40 +0200 (CEST) Date: Sun, 4 Jun 2023 16:25:40 +0200 From: Stefano Sabatini To: FFmpeg development discussions and patches Message-ID: <20230604142540.GA4274@mariano> Mail-Followup-To: FFmpeg development discussions and patches References: <20230501114456.13898-1-epirat07@gmail.com> <20230521235235.GC14958@mariano> <8CA999C7-1502-4FAB-ACD9-9BC02ED68058@gmail.com> <20230526060544.GB3241@mariano> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.13.2 (2019-12-18) Subject: Re: [FFmpeg-devel] [PATCH 1/3] avutil/dict: add av_dict_pop X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On date Friday 2023-05-26 11:11:48 +0200, Marvin Scholz wrote: > On 26 May 2023, at 8:05, Stefano Sabatini wrote: > > > On date Monday 2023-05-22 11:23:24 +0200, Marvin Scholz wrote: > >> On 22 May 2023, at 1:52, Stefano Sabatini wrote: [...] > > Should we also support the case with multiple same-key values? > > I don't see what could be improved there. You just call it multiple times, > or what do you mean? > > > > Also maybe we should mention that this operation might alterate the > > order of the entries (unless we add a new flag to shift the > > trailing data when an entry is removed). > > We currently IIRC nowhere give guarantees on the order of items in the > dict, which we probably should keep that way especially in regards to > your next point. OK, anyway this is pretty unrelated to the current patch (might be done as a followup). I was checking the current documentation and it's missing some important information (I'll try to send a patch to fix that later). [...] About your patch, please mention that the pop operation is destructive. We probably want to make that behavior configurable through flags, but I'm fine to keep the current behavior for consistency with the set(NULL) operation. [...] Thanks (sorry again for the slow reply). _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".