From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 2344C4608D for ; Sat, 3 Jun 2023 18:53:04 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1093A68BFD4; Sat, 3 Jun 2023 21:53:01 +0300 (EEST) Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [217.70.183.198]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5D79268BFD4 for ; Sat, 3 Jun 2023 21:52:55 +0300 (EEST) X-GND-Sasl: michael@niedermayer.cc Received: by mail.gandi.net (Postfix) with ESMTPSA id 65F02C0003 for ; Sat, 3 Jun 2023 18:52:54 +0000 (UTC) Date: Sat, 3 Jun 2023 20:52:53 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20230603185253.GZ1391451@pb2> References: <20230305114346.19875-1-michael@niedermayer.cc> <20230305190220.GC1928637@pb2> <20230521204700.GJ1391451@pb2> MIME-Version: 1.0 In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH 1/2] avcodec/rka: use 64bit for srate_pad computation X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============5558176041617806193==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============5558176041617806193== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="jMElxO9c2ypJyVNJ" Content-Disposition: inline --jMElxO9c2ypJyVNJ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, May 21, 2023 at 11:05:21PM +0200, Paul B Mahol wrote: > On 5/21/23, Michael Niedermayer wrote: > > On Sun, Mar 05, 2023 at 08:02:20PM +0100, Michael Niedermayer wrote: > >> On Sun, Mar 05, 2023 at 05:37:09PM +0100, Paul B Mahol wrote: > >> > On 3/5/23, Michael Niedermayer wrote: > >> > > Fixes: left shift of 538976288 by 13 places cannot be represented = in > >> > > type > >> > > 'int' > >> > > Fixes: > >> > > 56148/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_RKA_fuzzer= -6257370708967424 > >> > > > >> > > >> > Please make sure that this does not break decoding. > >> > >> how ? > >> > >> * Testing all rka files on the internet ? > >> i cannot > >> > >> * Reading the specification ? > >> i failed to find a public specification > >> > >> * Generating files that have a high enough sample rate with the binary > >> windows > >> encoder? > >> "ERROR: Unsupported format type." even at 88.2k, well below that point > >> > >> Also if it worked before its dependant on the compiler, its undefined > >> bahevior. > >> For files with more normal sample rates like the sample in our archieve > >> it produces the same output. > >> > >> Other ideas ? > > > > is above ok or should more testing be done ? >=20 > whatever. I assume you are ok with this being applied, so i will apply thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Asymptotically faster algorithms should always be preferred if you have asymptotical amounts of data --jMElxO9c2ypJyVNJ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZHuMAQAKCRBhHseHBAsP q/nCAJ4xZPFlaQ1tWR4IweNZ5ioyGxzFfACfZWPPZPaWw25CA4wfVl5e61DFTBU= =LpTq -----END PGP SIGNATURE----- --jMElxO9c2ypJyVNJ-- --===============5558176041617806193== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============5558176041617806193==--