From: Steven Liu <lq@chinaffmpeg.org> To: ffmpeg-devel@ffmpeg.org Cc: Steven Liu <lq@chinaffmpeg.org> Subject: [FFmpeg-devel] [PATCH v11 2/6] avformat/flvdec: support demux hevc in enhanced flv Date: Fri, 2 Jun 2023 15:31:05 +0800 Message-ID: <20230602073109.14086-3-lq@chinaffmpeg.org> (raw) In-Reply-To: <20230602073109.14086-1-lq@chinaffmpeg.org> Signed-off-by: Steven Liu <lq@chinaffmpeg.org> --- libavformat/flvdec.c | 58 ++++++++++++++++++++++++++++++++++++++------ 1 file changed, 50 insertions(+), 8 deletions(-) diff --git a/libavformat/flvdec.c b/libavformat/flvdec.c index d83edff727..c8e6cadf1c 100644 --- a/libavformat/flvdec.c +++ b/libavformat/flvdec.c @@ -79,6 +79,8 @@ typedef struct FLVContext { int64_t last_ts; int64_t time_offset; int64_t time_pos; + + uint8_t exheader; } FLVContext; /* AMF date type */ @@ -302,13 +304,25 @@ static void flv_set_audio_codec(AVFormatContext *s, AVStream *astream, } } -static int flv_same_video_codec(AVCodecParameters *vpar, int flags) +static int flv_same_video_codec(AVFormatContext *s, AVCodecParameters *vpar, int flags) { int flv_codecid = flags & FLV_VIDEO_CODECID_MASK; + FLVContext *flv = s->priv_data; if (!vpar->codec_id && !vpar->codec_tag) return 1; + if (flv->exheader) { + uint8_t *codec_id_str = (uint8_t *)s->pb->buf_ptr; + uint32_t codec_id = codec_id_str[3] | codec_id_str[2] << 8 | codec_id_str[1] << 16 | codec_id_str[0] << 24; + switch(codec_id) { + case MKBETAG('h', 'v', 'c', '1'): + return vpar->codec_id == AV_CODEC_ID_HEVC; + default: + break; + } + } + switch (flv_codecid) { case FLV_CODECID_H263: return vpar->codec_id == AV_CODEC_ID_FLV1; @@ -331,9 +345,24 @@ static int flv_set_video_codec(AVFormatContext *s, AVStream *vstream, int flv_codecid, int read) { FFStream *const vstreami = ffstream(vstream); + FLVContext *flv = s->priv_data; int ret = 0; AVCodecParameters *par = vstream->codecpar; enum AVCodecID old_codec_id = vstream->codecpar->codec_id; + flv_codecid &= FLV_VIDEO_CODECID_MASK; + + if (flv->exheader) { + uint32_t codec_id = avio_rb32(s->pb); + + switch(codec_id) { + case MKBETAG('h', 'v', 'c', '1'): + par->codec_id = AV_CODEC_ID_HEVC; + vstreami->need_parsing = AVSTREAM_PARSE_HEADERS; + return 4; + default: + break; + } + } switch (flv_codecid) { case FLV_CODECID_H263: par->codec_id = AV_CODEC_ID_FLV1; @@ -796,6 +825,7 @@ static int flv_read_header(AVFormatContext *s) s->start_time = 0; flv->sum_flv_tag_size = 0; flv->last_keyframe_stream_index = -1; + flv->exheader = 0; return 0; } @@ -1071,6 +1101,11 @@ retry: } else if (type == FLV_TAG_TYPE_VIDEO) { stream_type = FLV_STREAM_TYPE_VIDEO; flags = avio_r8(s->pb); + /* + * Reference Enhancing FLV 2023-03-v1.0.0-B.8 + * https://github.com/veovera/enhanced-rtmp/blob/main/enhanced-rtmp-v1.pdf + * */ + flv->exheader = (flags >> 7) & 1; size--; if ((flags & FLV_VIDEO_FRAMETYPE_MASK) == FLV_FRAME_VIDEO_INFO_CMD) goto skip; @@ -1129,7 +1164,7 @@ skip: break; } else if (stream_type == FLV_STREAM_TYPE_VIDEO) { if (st->codecpar->codec_type == AVMEDIA_TYPE_VIDEO && - (s->video_codec_id || flv_same_video_codec(st->codecpar, flags))) + (s->video_codec_id || flv_same_video_codec(s, st->codecpar, flags))) break; } else if (stream_type == FLV_STREAM_TYPE_SUBTITLE) { if (st->codecpar->codec_type == AVMEDIA_TYPE_SUBTITLE) @@ -1230,7 +1265,7 @@ retry_duration: avcodec_parameters_free(&par); } } else if (stream_type == FLV_STREAM_TYPE_VIDEO) { - int ret = flv_set_video_codec(s, st, flags & FLV_VIDEO_CODECID_MASK, 1); + int ret = flv_set_video_codec(s, st, flags, 1); if (ret < 0) return ret; size -= ret; @@ -1242,16 +1277,23 @@ retry_duration: if (st->codecpar->codec_id == AV_CODEC_ID_AAC || st->codecpar->codec_id == AV_CODEC_ID_H264 || - st->codecpar->codec_id == AV_CODEC_ID_MPEG4) { - int type = avio_r8(s->pb); - size--; + st->codecpar->codec_id == AV_CODEC_ID_MPEG4 || + st->codecpar->codec_id == AV_CODEC_ID_HEVC) { + int type = 0; + if (flv->exheader && stream_type == FLV_STREAM_TYPE_VIDEO) { + type = flags & 0x0F; + } else { + type = avio_r8(s->pb); + size--; + } if (size < 0) { ret = AVERROR_INVALIDDATA; goto leave; } - if (st->codecpar->codec_id == AV_CODEC_ID_H264 || st->codecpar->codec_id == AV_CODEC_ID_MPEG4) { + if (st->codecpar->codec_id == AV_CODEC_ID_H264 || st->codecpar->codec_id == AV_CODEC_ID_MPEG4 || + (st->codecpar->codec_id == AV_CODEC_ID_HEVC && type == PacketTypeCodedFrames)) { // sign extension int32_t cts = (avio_rb24(s->pb) + 0xff800000) ^ 0xff800000; pts = av_sat_add64(dts, cts); @@ -1267,7 +1309,7 @@ retry_duration: } } if (type == 0 && (!st->codecpar->extradata || st->codecpar->codec_id == AV_CODEC_ID_AAC || - st->codecpar->codec_id == AV_CODEC_ID_H264)) { + st->codecpar->codec_id == AV_CODEC_ID_H264 || st->codecpar->codec_id == AV_CODEC_ID_HEVC)) { AVDictionaryEntry *t; if (st->codecpar->extradata) { -- 2.40.0 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-06-02 7:32 UTC|newest] Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-04-13 9:44 [FFmpeg-devel] [PATCH v8 0/6] Suppor hevc av1 and vp9 codec " Steven Liu 2023-04-13 9:44 ` [FFmpeg-devel] [PATCH v8 1/6] avformat/flvenc: Add support for HEVC over flv in muxer Steven Liu 2023-05-11 17:58 ` Andreas Rheinhardt 2023-05-12 3:58 ` [FFmpeg-devel] [PATCH v9 0/6] Support enhanced flv in FFmpeg Steven Liu 2023-05-12 3:58 ` [FFmpeg-devel] [PATCH v9 1/6] avformat/flvenc: Add support for HEVC over flv in muxer Steven Liu 2023-05-12 3:58 ` [FFmpeg-devel] [PATCH v9 2/6] avformat/flvdec: support demux hevc in enhanced flv Steven Liu 2023-05-12 3:58 ` [FFmpeg-devel] [PATCH v9 3/6] avformat/flvenc: support mux av1 " Steven Liu 2023-05-12 3:58 ` [FFmpeg-devel] [PATCH v9 4/6] avformat/flvdec: support demux " Steven Liu 2023-05-12 3:59 ` [FFmpeg-devel] [PATCH v9 5/6] avformat/flvenc: support mux vp9 " Steven Liu 2023-05-12 3:59 ` [FFmpeg-devel] [PATCH v9 6/6] avformat/flvenc: support demux " Steven Liu 2023-05-12 10:31 ` [FFmpeg-devel] [PATCH v9 0/6] Support enhanced flv in FFmpeg Timo Rothenpieler 2023-05-12 10:47 ` Steven Liu 2023-05-12 11:06 ` Timo Rothenpieler 2023-05-12 10:47 ` Vibhoothi 2023-05-12 11:59 ` Steven Liu 2023-05-13 2:40 ` Neal Gompa 2023-05-15 8:31 ` [FFmpeg-devel] [PATCH v10 " Steven Liu 2023-05-15 8:31 ` [FFmpeg-devel] [PATCH v10 1/6] avformat/flvenc: support mux hevc in enhanced flv Steven Liu 2023-05-15 8:31 ` [FFmpeg-devel] [PATCH v10 2/6] avformat/flvdec: support demux " Steven Liu 2023-05-15 8:31 ` [FFmpeg-devel] [PATCH v10 3/6] avformat/flvenc: support mux av1 " Steven Liu 2023-06-02 4:49 ` Tristan Matthews 2023-06-02 7:19 ` Steven Liu 2023-06-02 7:31 ` [FFmpeg-devel] [PATCH v11 0/6] Support enhanced flv in FFmpeg Steven Liu 2023-06-02 7:31 ` [FFmpeg-devel] [PATCH v11 1/6] avformat/flvenc: support mux hevc in enhanced flv Steven Liu 2023-06-02 11:08 ` Lance Wang 2023-06-02 11:28 ` Steven Liu 2023-06-02 15:52 ` Lance Wang 2023-06-02 23:44 ` Steven Liu 2023-06-02 7:31 ` Steven Liu [this message] 2023-06-02 11:15 ` [FFmpeg-devel] [PATCH v11 2/6] avformat/flvdec: support demux " Lance Wang 2023-06-02 7:31 ` [FFmpeg-devel] [PATCH v11 3/6] avformat/flvenc: support mux av1 " Steven Liu 2023-06-02 7:31 ` [FFmpeg-devel] [PATCH v11 4/6] avformat/flvdec: support demux " Steven Liu 2023-06-02 7:31 ` [FFmpeg-devel] [PATCH v11 5/6] avformat/flvenc: support mux vp9 " Steven Liu 2023-06-02 7:31 ` [FFmpeg-devel] [PATCH v11 6/6] avformat/flvdec: support demux " Steven Liu 2023-05-15 8:31 ` [FFmpeg-devel] [PATCH v10 4/6] avformat/flvdec: support demux av1 " Steven Liu 2023-05-15 8:32 ` [FFmpeg-devel] [PATCH v10 5/6] avformat/flvenc: support mux vp9 " Steven Liu 2023-05-15 8:32 ` [FFmpeg-devel] [PATCH v10 6/6] avformat/flvdec: support demux " Steven Liu 2023-05-15 20:41 ` [FFmpeg-devel] [PATCH v10 0/6] Support enhanced flv in FFmpeg Neal Gompa 2023-05-31 5:47 ` Neal Gompa 2023-06-01 0:02 ` Steven Liu 2023-06-01 5:03 ` Tristan Matthews 2023-06-01 6:07 ` Steven Liu 2023-06-01 17:57 ` Tristan Matthews 2023-06-02 1:37 ` Steven Liu 2023-06-01 9:29 ` Jean-Baptiste Kempf 2023-07-17 11:37 ` Jean-Baptiste Kempf 2023-07-17 14:07 ` Steven Liu 2023-06-06 6:42 ` Steven Liu 2023-06-08 0:02 ` Neal Gompa 2023-06-09 22:46 ` Tristan Matthews 2023-05-15 8:37 ` [FFmpeg-devel] [PATCH v9 " Steven Liu 2023-04-13 9:44 ` [FFmpeg-devel] [PATCH v8 2/6] avformat/flvdec: support demux hevc in enhanced flv Steven Liu 2023-07-26 23:27 ` Michael Niedermayer 2023-07-27 2:43 ` Steven Liu 2023-04-13 9:44 ` [FFmpeg-devel] [PATCH v8 3/6] avformat/flvenc: support mux av1 " Steven Liu 2023-05-08 23:07 ` Neal Gompa 2023-05-09 1:55 ` Steven Liu 2023-05-09 2:41 ` Neal Gompa 2023-05-09 4:14 ` Gyan Doshi 2023-05-09 10:35 ` Neal Gompa 2023-05-09 10:48 ` Gyan Doshi 2023-05-10 11:05 ` Neal Gompa 2023-05-10 11:13 ` Steven Liu 2023-05-11 1:31 ` Neal Gompa 2023-05-11 1:40 ` Steven Liu 2023-05-11 16:21 ` Neal Gompa 2023-05-11 16:26 ` Jean-Baptiste Kempf 2023-05-12 3:35 ` Neal Gompa 2023-05-12 5:23 ` Jean-Baptiste Kempf 2023-04-13 9:44 ` [FFmpeg-devel] [PATCH v8 4/6] avformat/flvdec: support demux " Steven Liu 2023-04-13 9:44 ` [FFmpeg-devel] [PATCH v8 5/6] avformat/flvenc: support mux vp9 " Steven Liu 2023-04-13 9:44 ` [FFmpeg-devel] [PATCH v8 6/6] avformat/flvenc: support demux " Steven Liu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230602073109.14086-3-lq@chinaffmpeg.org \ --to=lq@chinaffmpeg.org \ --cc=ffmpeg-devel@ffmpeg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git