From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 5B830466AD for ; Wed, 31 May 2023 17:03:01 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6E284680AA3; Wed, 31 May 2023 20:02:57 +0300 (EEST) Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3994068BE4A for ; Wed, 31 May 2023 20:02:51 +0300 (EEST) X-GND-Sasl: michael@niedermayer.cc Received: by mail.gandi.net (Postfix) with ESMTPSA id 6F2246000B for ; Wed, 31 May 2023 17:02:50 +0000 (UTC) Date: Wed, 31 May 2023 19:02:49 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20230531170249.GU1391451@pb2> References: <20230528194345.GP1391451@pb2> <20230529124955.16095-1-anton@khirnov.net> MIME-Version: 1.0 In-Reply-To: <20230529124955.16095-1-anton@khirnov.net> Subject: Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg: rework setting sub2video parameters X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============6031985954770328286==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============6031985954770328286== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="dv5GTjvIKRsTi/dI" Content-Disposition: inline --dv5GTjvIKRsTi/dI Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, May 29, 2023 at 02:49:55PM +0200, Anton Khirnov wrote: > Set them in ifilter_parameters_from_dec(), similarly to audio/video > streams. This reduces the extent to which sub2video filters need to be > treated specially. > --- > You can also get the updated tree from ffmpeg_sub2video in my repo > --- > fftools/ffmpeg.c | 6 ++--- > fftools/ffmpeg_demux.c | 21 +++++++++++++++ > fftools/ffmpeg_filter.c | 58 ++++++++++++----------------------------- > 3 files changed, 41 insertions(+), 44 deletions(-) breaks (looks like wrong width/height) after the change from ffmpeg_sub2vid= eo corresponding to this patch ./ffmpeg -i ~/tickets/4752/dump_dvbsubtitles.mp4 -y -ss 5 -t 1 -filter_co= mplex '[0:v][0:s]overlay' /tmp/file4752.ts && ffplay /tmp/file4752.ts seems to be in ffmpeg-bugs/trac/ticket4752/dump_dvbsubtitles.mp4 thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB I do not agree with what you have to say, but I'll defend to the death your right to say it. -- Voltaire --dv5GTjvIKRsTi/dI Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZHd9tAAKCRBhHseHBAsP q/qJAJ9VyCOMUBsUAsl2mBcX0nckaNa5twCdGWlAE14FsGa13QcI5LrKOa9ZvwQ= =+KIT -----END PGP SIGNATURE----- --dv5GTjvIKRsTi/dI-- --===============6031985954770328286== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============6031985954770328286==--