From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id C1C794667A for ; Tue, 30 May 2023 12:31:41 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id DF3B268C23A; Tue, 30 May 2023 15:30:56 +0300 (EEST) Received: from haasn.dev (haasn.dev [78.46.187.166]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6C93B68C225 for ; Tue, 30 May 2023 15:30:53 +0300 (EEST) Received: from haasn.dev (unknown [10.30.0.2]) by haasn.dev (Postfix) with ESMTP id 8F9CF4025C; Tue, 30 May 2023 14:30:52 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=haasn.xyz; s=mail; t=1685449853; bh=VeptAi1Nl3MGpen/u6GxuLEniEozd1zCeNdjgIxCX7Y=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=vQcQWyPXpOEOwr0bd6naB6zCZ4oXsGKFSICaiIRfSzLIJecyI4gm+23FkWUZ/yCRp 5SE9uZq4E5Mcy343UkG4GXtoW8r3KFztenMefqQKDMIdbTz8WPtY+5KUVqGkJpVB7+ l8a3hwPV1oukPJabBMgyc++lihP0B9BhxQqw3RPo= Date: Tue, 30 May 2023 14:30:51 +0200 Message-ID: <20230530143051.GB129294@haasn.xyz> From: Niklas Haas To: ffmpeg-devel@ffmpeg.org In-Reply-To: <20230530015854.31900-1-epirat07@gmail.com> References: <20230530013359.31434-1-epirat07@gmail.com> <20230530015854.31900-1-epirat07@gmail.com> MIME-Version: 1.0 Content-Disposition: inline Subject: Re: [FFmpeg-devel] [PATCH v2] libavfilter: add vf_xfade_vulkan X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Marvin Scholz Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Tue, 30 May 2023 03:58:54 +0200 Marvin Scholz wrote: > +static const char transition_fade[] = { > + C(0, void transition(int idx, ivec2 pos, float progress) ) > + C(0, { ) > + C(1, vec4 a = texture(a_images[idx], pos); ) > + C(1, vec4 b = texture(b_images[idx], pos); ) > + C(1, imageStore(output_images[idx], pos, mix(b, a, progress)); ) > + C(0, } ) > +}; This seems inverted compared to logic in vf_xfade. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".