From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <ffmpeg-devel-bounces@ffmpeg.org> Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 8B55D45C3A for <ffmpegdev@gitmailbox.com>; Sun, 28 May 2023 19:43:58 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D631F68C194; Sun, 28 May 2023 22:43:54 +0300 (EEST) Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E9D5268BE95 for <ffmpeg-devel@ffmpeg.org>; Sun, 28 May 2023 22:43:47 +0300 (EEST) X-GND-Sasl: michael@niedermayer.cc Received: by mail.gandi.net (Postfix) with ESMTPSA id F3688240003 for <ffmpeg-devel@ffmpeg.org>; Sun, 28 May 2023 19:43:46 +0000 (UTC) Date: Sun, 28 May 2023 21:43:45 +0200 From: Michael Niedermayer <michael@niedermayer.cc> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Message-ID: <20230528194345.GP1391451@pb2> References: <20230528091416.17927-1-anton@khirnov.net> <20230528091416.17927-16-anton@khirnov.net> MIME-Version: 1.0 In-Reply-To: <20230528091416.17927-16-anton@khirnov.net> Subject: Re: [FFmpeg-devel] [PATCH 16/24] fftools/ffmpeg: rework setting sub2video parameters X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org> List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe> List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel> List-Post: <mailto:ffmpeg-devel@ffmpeg.org> List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help> List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe> Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Content-Type: multipart/mixed; boundary="===============2424832936595727834==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org> Archived-At: <https://master.gitmailbox.com/ffmpegdev/20230528194345.GP1391451@pb2/> List-Archive: <https://master.gitmailbox.com/ffmpegdev/> List-Post: <mailto:ffmpegdev@gitmailbox.com> --===============2424832936595727834== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="6tk3Tc7DvQ0rvXK2" Content-Disposition: inline --6tk3Tc7DvQ0rvXK2 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, May 28, 2023 at 11:14:08AM +0200, Anton Khirnov wrote: > Set them in ifilter_parameters_from_dec(), similarly to audio/video > streams. This reduces the extent to which sub2video filters need to be > treated specially. > --- > fftools/ffmpeg.c | 6 ++--- > fftools/ffmpeg_demux.c | 21 +++++++++++++++++ > fftools/ffmpeg_filter.c | 52 +++++++++++------------------------------ > 3 files changed, 38 insertions(+), 41 deletions(-) The following prodeuces a 0 byte file after the patch -i ~/tickets/153/bbc_small.ts -filter_complex '[0:v][0:s]overlay' -qscale = 2 -t 3 -y notcorrupt.avi https://samples.ffmpeg.org/ffmpeg-bugs/trac/ticket153/bbc_small.ts thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB I am the wisest man alive, for I know one thing, and that is that I know nothing. -- Socrates --6tk3Tc7DvQ0rvXK2 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZHOu7QAKCRBhHseHBAsP q4dCAJ0SBeS6OQciNHLyZXaahxYvl7TSHACfRyTThu+0XQrOWv2ZE2yo+xwxR18= =zKxa -----END PGP SIGNATURE----- --6tk3Tc7DvQ0rvXK2-- --===============2424832936595727834== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============2424832936595727834==--