From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTP id 314C145FEA
	for <ffmpegdev@gitmailbox.com>; Mon, 29 May 2023 01:20:52 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9865B68C157;
	Mon, 29 May 2023 04:20:49 +0300 (EEST)
Received: from mail.overt.org (mail.overt.org [72.14.183.176])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id BCFC568AFA8
 for <ffmpeg-devel@ffmpeg.org>; Mon, 29 May 2023 04:20:42 +0300 (EEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=overt.org; s=mail;
 t=1685323239; bh=/Yu2Uo566dZA4KrhSunH/c7obTzVF22xzLMjlFNlclY=;
 h=Date:From:To:Subject:In-Reply-To:References:From;
 b=paHdN1pdtC13+CDtclDCD11Vk12dcjlAs6woJZKJJGdClq56MaxWJsYAJmmSUtMqn
 mVRGTGFFh9GsWH5uMr9kME7LxY7pxqKqRHYaiS/dn/oisozf2p1BRvcokqjrUtCWm6
 aTZifQENVQsbROECm9eCDikqXWWqO+6qoSfIzrGgk8bMvpaTUPUDdpv7Xy44LCWnoU
 YXU8LzOnSLq0Rm8Sh0EFa6bgTFfXTQGaMutDaR/f99Pgs7O0TtUpNi+kZYsQ/KoCw/
 /IkezgzHdYjWyW7xFLq4Z4Rm41zxqnwALc7jovx+Xk1+H1SDkrHasUdMVNYIPwmM6d
 ZTOQT39P6zRfw==
Received: from authenticated-user (mail.overt.org [72.14.183.176])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest
 SHA256) (No client certificate requested)
 by mail.overt.org (Postfix) with ESMTPSA id E25496069F
 for <ffmpeg-devel@ffmpeg.org>; Sun, 28 May 2023 20:20:38 -0500 (CDT)
Date: Sun, 28 May 2023 18:20:37 -0700
From: Philip Langdale <philipl@overt.org>
To: ffmpeg-devel@ffmpeg.org
Message-ID: <20230528182037.1e906329@fido7>
In-Reply-To: <NWZse6z--3-9@lynne.ee>
References: <NWZse6z--3-9@lynne.ee>
MIME-Version: 1.0
Subject: Re: [FFmpeg-devel] [PATCH] vulkan_decode: check if yuv_sampler
 exists before freeing it
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/20230528182037.1e906329@fido7/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>

On Mon, 29 May 2023 02:22:34 +0200 (CEST)
Lynne <dev@lynne.ee> wrote:

> No Vulkan function is NULL-safe, for no real reason, despite
> the language defining and returning VK_NULL_HANDLE.
> 
> Patch attached.
> 

Tested and works. I will note that both the function and s->hwctx are
null in the failure case and if ctx->sampler could exist without those
also being non-null, you could segfault again. I assume this won't
happen in practice.

ship it.

--phil
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".