Re: [FFmpeg-devel] [PATCH] avformat/gifdec: cleanup

From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] avformat/gifdec: cleanup
Date: Tue, 23 May 2023 23:51:12 +0200
Message-ID: <20230523215112.GL1391451@pb2> (raw)
In-Reply-To: <CAPYw7P6KA_NPWYvsiHLR=BGkaufGgebXA1mZ=8Owi-=MaJ28Pg@mail.gmail.com>

[-- Attachment #1.1: Type: text/plain, Size: 1567 bytes --]

On Mon, May 22, 2023 at 06:19:09PM +0200, Paul B Mahol wrote:
> On 5/21/23, Paul B Mahol <onemda@gmail.com> wrote:
> > Attached patches.
> >
> > This finally removes giant hacks in gif demuxer and allows using gif
> > files via pipe reliably.
> >
> 
> Hopefully final version.

[...]

>  libavcodec/gifdec.c      |   11 +-
>  libavformat/gifdec.c     |  244 +++++++++++------------------------------------
>  tests/ref/fate/gif-demux |    2 
>  3 files changed, 70 insertions(+), 187 deletions(-)
> 8624c021a27e9ac3d18db4e560179c3fe359953f  0002-avformat-gifdec-switch-to-using-gif-parser.patch
> From 899afe00bf969b8c47c6fb5afbde3a8f9be1536d Mon Sep 17 00:00:00 2001
> From: Paul B Mahol <onemda@gmail.com>
> Date: Sat, 20 May 2023 14:13:27 +0200
> Subject: [PATCH 2/2] avformat/gifdec: switch to using gif parser
> 
> Update fate test, more correct as last packet is not truncated.
> 
> Signed-off-by: Paul B Mahol <onemda@gmail.com>
> ---
>  libavcodec/gifdec.c      |  11 +-
>  libavformat/gifdec.c     | 244 ++++++++++-----------------------------
>  tests/ref/fate/gif-demux |   2 +-
>  3 files changed, 70 insertions(+), 187 deletions(-)

seems to break resyncing

./ffmpeg -y  -f gif -i resync.gif -bitexact resync.nut

file at:
https://samples.ffmpeg.org/image-samples/GIF/resync.gif

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Dictatorship naturally arises out of democracy, and the most aggravated
form of tyranny and slavery out of the most extreme liberty. -- Plato

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".