From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 8F4A045F97 for ; Mon, 22 May 2023 23:36:58 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 24DCD68C13B; Tue, 23 May 2023 02:36:16 +0300 (EEST) Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A301268C0F4 for ; Tue, 23 May 2023 02:36:07 +0300 (EEST) Received: (Authenticated sender: michael@niedermayer.cc) by mail.gandi.net (Postfix) with ESMTPSA id DB311240003 for ; Mon, 22 May 2023 23:36:06 +0000 (UTC) From: Michael Niedermayer To: FFmpeg development discussions and patches Date: Tue, 23 May 2023 01:36:01 +0200 Message-Id: <20230522233601.20552-6-michael@niedermayer.cc> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230522233601.20552-1-michael@niedermayer.cc> References: <20230522233601.20552-1-michael@niedermayer.cc> Subject: [FFmpeg-devel] [PATCH 6/6] avcodec/kbdwin: Remove low precision intermediate in ff_kbd_window_init_fixed() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Previously floats where scaled up to 32bit int, but floats do not have 32bits in their mantisse so a quarter of the bits where nonsense. It seems no fate test is affected by this change, which is interresting Signed-off-by: Michael Niedermayer --- libavcodec/kbdwin.c | 20 +++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/libavcodec/kbdwin.c b/libavcodec/kbdwin.c index e2f6491124..163f9d5251 100644 --- a/libavcodec/kbdwin.c +++ b/libavcodec/kbdwin.c @@ -21,7 +21,7 @@ #include "libavutil/attributes.h" #include "kbdwin.h" -av_cold void ff_kbd_window_init(float *window, float alpha, int n) +av_cold static void kbd_window_init(float *float_window, int *int_window, float alpha, int n) { int i; double sum = 0.0, tmp; @@ -40,20 +40,22 @@ av_cold void ff_kbd_window_init(float *window, float alpha, int n) for (i = 0; i <= n / 2; i++) { sum += temp[i]; - window[i] = sqrt(sum * scale); + if (float_window) float_window[i] = sqrt(sum * scale); + else int_window[i] = lrint(2147483647 * sqrt(sum * scale)); } for (; i < n; i++) { sum += temp[n - i]; - window[i] = sqrt(sum * scale); + if (float_window) float_window[i] = sqrt(sum * scale); + else int_window[i] = lrint(2147483647 * sqrt(sum * scale)); } } -av_cold void ff_kbd_window_init_fixed(int32_t *window, float alpha, int n) +av_cold void ff_kbd_window_init(float *window, float alpha, int n) { - int i; - float local_window[FF_KBD_WINDOW_MAX]; + kbd_window_init(window, NULL, alpha, n); +} - ff_kbd_window_init(local_window, alpha, n); - for (i = 0; i < n; i++) - window[i] = (int)floor(2147483647.0 * local_window[i] + 0.5); +av_cold void ff_kbd_window_init_fixed(int32_t *window, float alpha, int n) +{ + kbd_window_init(NULL, window, alpha, n); } -- 2.17.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".