From: Michael Niedermayer <michael@niedermayer.cc> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Subject: [FFmpeg-devel] [PATCH 4/6] avcodec/kbdwin: Use av_bessel_i0() Date: Tue, 23 May 2023 01:35:59 +0200 Message-ID: <20230522233601.20552-4-michael@niedermayer.cc> (raw) In-Reply-To: <20230522233601.20552-1-michael@niedermayer.cc> Old code used about 7 times as many cpu cycles as new Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> --- libavcodec/kbdwin.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/libavcodec/kbdwin.c b/libavcodec/kbdwin.c index bf32aeb317..5dff334250 100644 --- a/libavcodec/kbdwin.c +++ b/libavcodec/kbdwin.c @@ -21,8 +21,6 @@ #include "libavutil/attributes.h" #include "kbdwin.h" -#define BESSEL_I0_ITER 50 // default: 50 iterations of Bessel I0 approximation - av_cold void ff_kbd_window_init(float *window, float alpha, int n) { int i, j; @@ -34,9 +32,7 @@ av_cold void ff_kbd_window_init(float *window, float alpha, int n) for (i = 0; i < n; i++) { tmp = i * (n - i) * alpha2; - bessel = 1.0; - for (j = BESSEL_I0_ITER; j > 0; j--) - bessel = bessel * tmp / (j * j) + 1; + bessel = av_bessel_i0(sqrt(tmp) * 2); sum += bessel; local_window[i] = sum; } -- 2.17.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-05-22 23:36 UTC|newest] Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-05-22 23:35 [FFmpeg-devel] [PATCH 1/6] Move bessel_i0() from swresample/resample to avutil/mathematics Michael Niedermayer 2023-05-22 23:35 ` [FFmpeg-devel] [PATCH 2/6] avfilter/asrc_sinc: Use av_bessel_i0() Michael Niedermayer 2023-05-22 23:35 ` [FFmpeg-devel] [PATCH 3/6] avfilter/window_func: " Michael Niedermayer 2023-05-22 23:35 ` Michael Niedermayer [this message] 2023-05-22 23:36 ` [FFmpeg-devel] [PATCH 5/6] avcodec/kbdwin: Avoid computing bessel values twice Michael Niedermayer 2023-05-22 23:36 ` [FFmpeg-devel] [PATCH 6/6] avcodec/kbdwin: Remove low precision intermediate in ff_kbd_window_init_fixed() Michael Niedermayer 2023-05-28 21:15 ` [FFmpeg-devel] [PATCH 1/6] Move bessel_i0() from swresample/resample to avutil/mathematics Michael Niedermayer
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230522233601.20552-4-michael@niedermayer.cc \ --to=michael@niedermayer.cc \ --cc=ffmpeg-devel@ffmpeg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git