Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: [FFmpeg-devel] [PATCH 3/6] avfilter/window_func: Use av_bessel_i0()
Date: Tue, 23 May 2023 01:35:58 +0200
Message-ID: <20230522233601.20552-3-michael@niedermayer.cc> (raw)
In-Reply-To: <20230522233601.20552-1-michael@niedermayer.cc>

Old code needed about 6 times as long as new with defaults in afftfilt

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
---
 libavfilter/window_func.h | 20 +++++---------------
 1 file changed, 5 insertions(+), 15 deletions(-)

diff --git a/libavfilter/window_func.h b/libavfilter/window_func.h
index 02b5def9dd..13236d8593 100644
--- a/libavfilter/window_func.h
+++ b/libavfilter/window_func.h
@@ -25,6 +25,7 @@
 #include <math.h>
 #include "libavutil/avassert.h"
 #include "libavutil/common.h"
+#include "libavutil/timer.h"
 
 enum WindowFunc     { WFUNC_RECT, WFUNC_HANNING, WFUNC_HAMMING, WFUNC_BLACKMAN,
                       WFUNC_BARTLETT, WFUNC_WELCH, WFUNC_FLATTOP,
@@ -59,19 +60,6 @@ enum WindowFunc     { WFUNC_RECT, WFUNC_HANNING, WFUNC_HAMMING, WFUNC_BLACKMAN,
         { "bohman",   "Bohman",           0, AV_OPT_TYPE_CONST, {.i64=WFUNC_BOHMAN},   0, 0, flag, "win_func" }, \
         { "kaiser",   "Kaiser",           0, AV_OPT_TYPE_CONST, {.i64=WFUNC_KAISER},   0, 0, flag, "win_func" }
 
-static inline double get_i0(double x)
-{
-    double y = 1.0, prev = 1.0, i = 1.0;
-
-    while (fabs(prev) > 1e-20) {
-        double summand = prev * x * x / (4 * i * i);
-        y += summand;
-        prev = summand;
-        i++;
-    }
-
-    return y;
-}
 
 static inline void generate_window_func(float *lut, int N, int win_func,
                                         float *overlap)
@@ -232,13 +220,15 @@ static inline void generate_window_func(float *lut, int N, int win_func,
         *overlap = 0.75;
         break;
     case WFUNC_KAISER:
+    {
+        double scale = 1.0 / av_bessel_i0(12.);
         for (n = 0; n < N; n++) {
             double x = 2.0 / (double)(N - 1);
-
-            lut[n] = get_i0(12. * sqrt(1. - SQR(n * x - 1.))) / get_i0(12.);
+            lut[n] = av_bessel_i0(12. * sqrt(1. - SQR(n * x - 1.))) * scale;
         }
         *overlap = 0.75;
         break;
+    }
     default:
         av_assert0(0);
     }
-- 
2.17.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  parent reply	other threads:[~2023-05-22 23:36 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-22 23:35 [FFmpeg-devel] [PATCH 1/6] Move bessel_i0() from swresample/resample to avutil/mathematics Michael Niedermayer
2023-05-22 23:35 ` [FFmpeg-devel] [PATCH 2/6] avfilter/asrc_sinc: Use av_bessel_i0() Michael Niedermayer
2023-05-22 23:35 ` Michael Niedermayer [this message]
2023-05-22 23:35 ` [FFmpeg-devel] [PATCH 4/6] avcodec/kbdwin: " Michael Niedermayer
2023-05-22 23:36 ` [FFmpeg-devel] [PATCH 5/6] avcodec/kbdwin: Avoid computing bessel values twice Michael Niedermayer
2023-05-22 23:36 ` [FFmpeg-devel] [PATCH 6/6] avcodec/kbdwin: Remove low precision intermediate in ff_kbd_window_init_fixed() Michael Niedermayer
2023-05-28 21:15 ` [FFmpeg-devel] [PATCH 1/6] Move bessel_i0() from swresample/resample to avutil/mathematics Michael Niedermayer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230522233601.20552-3-michael@niedermayer.cc \
    --to=michael@niedermayer.cc \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git