Re: [FFmpeg-devel] [PATCH 1/2] avcodec/rka: use 64bit for srate_pad computation

[Michael Niedermayer <michael@niedermayer.cc>]

[-- Attachment #1.1: Type: text/plain, Size: 1286 bytes --]

On Sun, Mar 05, 2023 at 08:02:20PM +0100, Michael Niedermayer wrote:
> On Sun, Mar 05, 2023 at 05:37:09PM +0100, Paul B Mahol wrote:
> > On 3/5/23, Michael Niedermayer <michael@niedermayer.cc> wrote:
> > > Fixes: left shift of 538976288 by 13 places cannot be represented in type
> > > 'int'
> > > Fixes:
> > > 56148/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_RKA_fuzzer-6257370708967424
> > >
> > 
> > Please make sure that this does not break decoding.
> 
> how ?
> 
> * Testing all rka files on the internet ? 
> i cannot
> 
> * Reading the specification ?
> i failed to find a public specification
> 
> * Generating files that have a high enough sample rate with the binary windows
>   encoder?
> "ERROR: Unsupported format type." even at 88.2k, well below that point
> 
> Also if it worked before its dependant on the compiler, its undefined
> bahevior.
> For files with more normal sample rates like the sample in our archieve
> it produces the same output.
> 
> Other ideas ?

is above ok or should more testing be done ?

thx

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

it is not once nor twice but times without number that the same ideas make
their appearance in the world. -- Aristotle

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".